From 7c43f8bb5e263c8509905fce2692909d2c15cc20 Mon Sep 17 00:00:00 2001 From: David Z Hao Date: Mon, 13 Apr 2026 13:43:33 -0700 Subject: [PATCH] Fix tui compilation (#17691) The recent release broke, codex suggested this as the fix Source failure: https://github.com/openai/codex/actions/runs/24362949066/job/71147202092 Probably from https://github.com/openai/codex/commit/ac82443d073f7f9a2248bad51bae2fa424ef4946 For why it got in: ``` The relevant setup: .github/workflows/rust-ci.yml (line 1) runs on PRs, but for codex-rs it only does: cargo fmt --check cargo shear argument-comment lint via Bazel no cargo check, no cargo clippy over the workspace, no cargo test over codex-tui .github/workflows/rust-ci-full.yml (line 1) runs on pushes to main and branches matching **full-ci**. That one does compile TUI because: codex-rs/Cargo.toml includes "tui" as a workspace member lint_build runs cargo clippy --target ... --tests --profile ... the matrix includes both dev and release profiles tests runs cargo nextest run ..., but only dev-profile tests Release CI also compiles it indirectly. .github/workflows/rust-release.yml (line 235) builds --bin codex, and cli/Cargo.toml (line 46) depends on codex-tui. ``` Codex tested locally with `cargo check -p codex-tui --release` and was able to repro, and verified that this fixed it --- codex-rs/tui/src/updates.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codex-rs/tui/src/updates.rs b/codex-rs/tui/src/updates.rs index 8de8d39c5..0acb30b34 100644 --- a/codex-rs/tui/src/updates.rs +++ b/codex-rs/tui/src/updates.rs @@ -70,7 +70,7 @@ struct HomebrewCaskInfo { } fn version_filepath(config: &Config) -> PathBuf { - config.codex_home.join(VERSION_FILENAME) + config.codex_home.join(VERSION_FILENAME).into_path_buf() } fn read_version_info(version_file: &Path) -> anyhow::Result {