From 5a82a72d935b7648fbd04462e2010eaa96783468 Mon Sep 17 00:00:00 2001 From: Ahmed Ibrahim Date: Tue, 13 Jan 2026 17:44:12 -0800 Subject: [PATCH] Use offline cache for tui migrations (#9186) --- codex-rs/tui/src/app.rs | 14 +++++++------- codex-rs/tui2/src/app.rs | 14 +++++++------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/codex-rs/tui/src/app.rs b/codex-rs/tui/src/app.rs index da54df948..560e6adc4 100644 --- a/codex-rs/tui/src/app.rs +++ b/codex-rs/tui/src/app.rs @@ -32,7 +32,6 @@ use codex_core::config::edit::ConfigEdit; use codex_core::config::edit::ConfigEditsBuilder; #[cfg(target_os = "windows")] use codex_core::features::Feature; -use codex_core::models_manager::manager::ModelsManager; use codex_core::models_manager::manager::RefreshStrategy; use codex_core::models_manager::model_presets::HIDE_GPT_5_1_CODEX_MAX_MIGRATION_PROMPT_CONFIG; use codex_core::models_manager::model_presets::HIDE_GPT5_1_MIGRATION_PROMPT_CONFIG; @@ -211,11 +210,8 @@ async fn handle_model_migration_prompt_if_needed( config: &mut Config, model: &str, app_event_tx: &AppEventSender, - models_manager: Arc, + available_models: Vec, ) -> Option { - let available_models = models_manager - .list_models(config, RefreshStrategy::OnlineIfUncached) - .await; let upgrade = available_models .iter() .find(|preset| preset.model == model) @@ -386,14 +382,18 @@ impl App { )); let mut model = thread_manager .get_models_manager() - .get_default_model(&config.model, &config, RefreshStrategy::OnlineIfUncached) + .get_default_model(&config.model, &config, RefreshStrategy::Offline) + .await; + let available_models = thread_manager + .get_models_manager() + .list_models(&config, RefreshStrategy::Offline) .await; let exit_info = handle_model_migration_prompt_if_needed( tui, &mut config, model.as_str(), &app_event_tx, - thread_manager.get_models_manager(), + available_models, ) .await; if let Some(exit_info) = exit_info { diff --git a/codex-rs/tui2/src/app.rs b/codex-rs/tui2/src/app.rs index 8e4763cbe..4009db530 100644 --- a/codex-rs/tui2/src/app.rs +++ b/codex-rs/tui2/src/app.rs @@ -49,7 +49,6 @@ use codex_core::config::Config; use codex_core::config::edit::ConfigEditsBuilder; #[cfg(target_os = "windows")] use codex_core::features::Feature; -use codex_core::models_manager::manager::ModelsManager; use codex_core::models_manager::manager::RefreshStrategy; use codex_core::models_manager::model_presets::HIDE_GPT_5_1_CODEX_MAX_MIGRATION_PROMPT_CONFIG; use codex_core::models_manager::model_presets::HIDE_GPT5_1_MIGRATION_PROMPT_CONFIG; @@ -248,11 +247,8 @@ async fn handle_model_migration_prompt_if_needed( config: &mut Config, model: &str, app_event_tx: &AppEventSender, - models_manager: Arc, + available_models: Vec, ) -> Option { - let available_models = models_manager - .list_models(config, RefreshStrategy::OnlineIfUncached) - .await; let upgrade = available_models .iter() .find(|preset| preset.model == model) @@ -454,14 +450,18 @@ impl App { )); let mut model = thread_manager .get_models_manager() - .get_default_model(&config.model, &config, RefreshStrategy::OnlineIfUncached) + .get_default_model(&config.model, &config, RefreshStrategy::Offline) + .await; + let available_models = thread_manager + .get_models_manager() + .list_models(&config, RefreshStrategy::Offline) .await; let exit_info = handle_model_migration_prompt_if_needed( tui, &mut config, model.as_str(), &app_event_tx, - thread_manager.get_models_manager(), + available_models, ) .await; if let Some(exit_info) = exit_info {