agent/codex
2
0
Fork 0
mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

Preserve assistant phase for replayed messages (#19832)

Browse Source
This commit is contained in:
friel-openai
2026-04-28 08:46:13 -07:00
committed by GitHub
Unverified
parent 21e19912e0
commit 598bbcdb58
8 changed files with 64 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/core/src/session/handlers.rs
+1
View File
@@ -1205,6 +1205,7 @@ Approved action:
let items = vec![ResponseInputItem::Message {
role: "developer".to_string(),
content: vec![ContentItem::InputText { text }],
phase: None,
}];
if let Err(items) = sess.inject_response_items(items).await {
codex-rs/core/src/session/mod.rs
+2
View File
@@ -1699,6 +1699,7 @@ impl Session {
.inject_response_items(vec![ResponseInputItem::Message {
role: "developer".to_string(),
content: vec![ContentItem::InputText { text }],
phase: None,
}])
.await
.is_err()
@@ -1795,6 +1796,7 @@ impl Session {
.inject_response_items(vec![ResponseInputItem::Message {
role: "developer".to_string(),
content: vec![ContentItem::InputText { text }],
phase: None,
}])
.await
.is_err()
codex-rs/core/src/session/tests.rs
+8 -1
View File
@@ -6432,6 +6432,7 @@ async fn task_finish_emits_turn_item_lifecycle_for_leftover_pending_user_input()
content: vec![ContentItem::InputText {
text: "late pending input".to_string(),
}],
phase: None,
}])
.await
.expect("inject pending input into active turn");
@@ -6677,18 +6678,21 @@ async fn prepend_pending_input_keeps_older_tail_ahead_of_newer_input() {
content: vec![ContentItem::InputText {
text: "blocked queued prompt".to_string(),
}],
phase: None,
};
let later = ResponseInputItem::Message {
role: "user".to_string(),
content: vec![ContentItem::InputText {
text: "later queued prompt".to_string(),
}],
phase: None,
};
let newer = ResponseInputItem::Message {
role: "user".to_string(),
content: vec![ContentItem::InputText {
text: "newer queued prompt".to_string(),
}],
phase: None,
};
sess.inject_response_items(vec![blocked.clone(), later.clone()])
@@ -6719,6 +6723,7 @@ async fn queued_response_items_for_next_turn_move_into_next_active_turn() {
content: vec![ContentItem::InputText {
text: "queued before wake".to_string(),
}],
phase: None,
};
sess.queue_response_items_for_next_turn(vec![queued_item.clone()])
@@ -6745,6 +6750,7 @@ async fn idle_interrupt_does_not_wake_queued_next_turn_items() {
content: vec![ContentItem::InputText {
text: "queued before interrupt".to_string(),
}],
phase: None,
};
sess.queue_response_items_for_next_turn(vec![queued_item])
@@ -6764,6 +6770,7 @@ async fn abort_empty_active_turn_preserves_pending_input() {
content: vec![ContentItem::InputText {
text: "late pending input".to_string(),
}],
phase: None,
};
let turn_state = {
let mut active = sess.active_turn.lock().await;
@@ -6969,7 +6976,7 @@ async fn budget_limited_accounting_steers_active_turn_without_aborting() -> anyh
.await?;
let pending_input = sess.get_pending_input().await;
let [ResponseInputItem::Message { role, content }] = pending_input.as_slice() else {
let [ResponseInputItem::Message { role, content, .. }] = pending_input.as_slice() else {
panic!("expected one budget-limit steering message, got {pending_input:#?}");
};
assert_eq!("developer", role);