From 5684c82e45f311d06ae81e1c1c2b1366a2fd25f1 Mon Sep 17 00:00:00 2001
From: Eric Traut <etraut@openai.com>
Date: Sun, 22 Feb 2026 12:12:36 -0800
Subject: [PATCH] Sort themes case-insensitively in picker (#12509)

## Summary
- order bundled and custom themes together by name while keeping entries
stable across platforms
- update the theme fixture names and tests to assert case-insensitive
ordering
---
 codex-rs/tui/src/render/highlight.rs | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/codex-rs/tui/src/render/highlight.rs b/codex-rs/tui/src/render/highlight.rs
index b0898ffe0..b87db29cb 100644
--- a/codex-rs/tui/src/render/highlight.rs
+++ b/codex-rs/tui/src/render/highlight.rs
@@ -321,8 +321,9 @@ pub(crate) fn list_available_themes(codex_home: Option<&Path>) -> Vec<ThemeEntry
         }
     }
 
-    // Keep picker ordering stable across platforms/filesystems.
-    entries.sort_by(|a, b| (a.is_custom, a.name.as_str()).cmp(&(b.is_custom, b.name.as_str())));
+    // Keep picker ordering stable across platforms/filesystems while sorting
+    // custom and bundled themes together, case-insensitively.
+    entries.sort_by_cached_key(|entry| (entry.name.to_ascii_lowercase(), entry.name.clone()));
 
     entries
 }
@@ -1012,7 +1013,7 @@ mod tests {
         let themes_dir = dir.path().join("themes");
         std::fs::create_dir(&themes_dir).unwrap();
         write_minimal_tmtheme(&themes_dir.join("zzz-custom.tmTheme"));
-        write_minimal_tmtheme(&themes_dir.join("aaa-custom.tmTheme"));
+        write_minimal_tmtheme(&themes_dir.join("Aaa-custom.tmTheme"));
         write_minimal_tmtheme(&themes_dir.join("mmm-custom.tmTheme"));
 
         let entries = list_available_themes(Some(dir.path()));
@@ -1022,11 +1023,11 @@ mod tests {
             .collect();
 
         let mut expected = actual.clone();
-        expected.sort_by(|a, b| (a.0, a.1.as_str()).cmp(&(b.0, b.1.as_str())));
+        expected.sort_by_cached_key(|entry| (entry.1.to_ascii_lowercase(), entry.1.clone()));
 
         assert_eq!(
             actual, expected,
-            "theme entries should be stable and sorted (builtins first, then custom by name)"
+            "theme entries should be stable and sorted case-insensitively across built-in and custom themes"
         );
     }