From 39ee1b96b009439f1914bd85f3b2e71fda33a1de Mon Sep 17 00:00:00 2001 From: rka-oai Date: Tue, 23 Jun 2026 11:03:35 -0700 Subject: [PATCH] [codex] Handle additional tools in rollout persistence metrics (#29672) ## Summary Handle `ResponseItem::AdditionalTools` in rollout persistence metrics. The persistence metrics match was added after the `AdditionalTools` variant and omitted it, causing release builds to fail with a non-exhaustive pattern error. This assigns the item the `response.additional_tools` metrics label. Release failure: https://github.com/openai/codex/actions/runs/28043786727/job/83016608475 ## Validation - `just fmt` - `just test -p codex-rollout` (76 passed) --- codex-rs/rollout/src/persistence_metrics.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/codex-rs/rollout/src/persistence_metrics.rs b/codex-rs/rollout/src/persistence_metrics.rs index 6f07dbdfd..c851ea624 100644 --- a/codex-rs/rollout/src/persistence_metrics.rs +++ b/codex-rs/rollout/src/persistence_metrics.rs @@ -256,6 +256,7 @@ fn turn_item_type(item: &TurnItem) -> &'static str { fn response_item_type(item: &ResponseItem) -> &'static str { match item { ResponseItem::Message { .. } => "response.message", + ResponseItem::AdditionalTools { .. } => "response.additional_tools", ResponseItem::AgentMessage { .. } => "response.agent_message", ResponseItem::Reasoning { .. } => "response.reasoning", ResponseItem::LocalShellCall { .. } => "response.local_shell_call",