From 1609f6aa815fe74942d7bd9410b5951894b53170 Mon Sep 17 00:00:00 2001 From: sayan-oai Date: Tue, 27 Jan 2026 18:24:24 -0800 Subject: [PATCH] fix: allow unknown fields on Notice in schema (#10041) the `notice` field didn't allow unknown fields in the schema, leading to issues where they shouldn't be. Now we allow unknown fields. image --- codex-rs/core/config.schema.json | 1 - codex-rs/core/src/config/types.rs | 1 - 2 files changed, 2 deletions(-) diff --git a/codex-rs/core/config.schema.json b/codex-rs/core/config.schema.json index 6b48dcb4a..1e164b24c 100644 --- a/codex-rs/core/config.schema.json +++ b/codex-rs/core/config.schema.json @@ -441,7 +441,6 @@ "type": "object" }, "Notice": { - "additionalProperties": false, "description": "Settings for notices we display to users via the tui and app-server clients (primarily the Codex IDE extension). NOTE: these are different from notifications - notices are warnings, NUX screens, acknowledgements, etc.", "properties": { "hide_full_access_warning": { diff --git a/codex-rs/core/src/config/types.rs b/codex-rs/core/src/config/types.rs index 96379dfa0..a1d126c11 100644 --- a/codex-rs/core/src/config/types.rs +++ b/codex-rs/core/src/config/types.rs @@ -472,7 +472,6 @@ const fn default_true() -> bool { /// (primarily the Codex IDE extension). NOTE: these are different from /// notifications - notices are warnings, NUX screens, acknowledgements, etc. #[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Default, JsonSchema)] -#[schemars(deny_unknown_fields)] pub struct Notice { /// Tracks whether the user has acknowledged the full access warning prompt. pub hide_full_access_warning: Option,