Commit Graph

10 Commits

  • feat(usage-query): decouple credentials from provider config
    Add independent credential fields for usage query to support different
    query endpoints and authentication methods.
    
    Changes:
    - Add `apiKey` and `baseUrl` fields to UsageScript struct
    - Remove dependency on provider config credentials in query_usage
    - Update test_usage_script to accept independent credential parameters
    - Add credential input fields in UsageScriptModal based on template:
      * General: apiKey + baseUrl
      * NewAPI: baseUrl + accessToken + userId
      * Custom: no additional fields (full freedom)
    - Auto-clear irrelevant fields when switching templates
    - Add i18n text for "credentialsConfig"
    
    Benefits:
    - Query API can use different endpoint/key than provider config
    - Better separation of concerns
    - More flexible for various usage query scenarios
  • chore: unify code formatting and remove unused code
    - Apply cargo fmt to Rust code with multiline error handling
    - Apply Prettier formatting to TypeScript code with trailing commas
    - Unify #[allow(non_snake_case)] attribute formatting
    - Remove unused ProviderNotFound error variant from error.rs
    - Add vitest-report.json to .gitignore to exclude test artifacts
    - Optimize readability of error handling chains with vertical alignment
    
    All tests passing: 22 Rust tests + 126 frontend tests
  • refactor(usage): consolidate query logic to eliminate DRY violations
    Breaking Changes:
    - Removed useAutoUsageQuery hook (119 lines)
    - Unified all usage queries into single useUsageQuery hook
    
    Technical Improvements:
    - Eliminated duplicate state management (React Query + manual useState)
    - Fixed single source of truth principle violation
    - Replaced manual setInterval with React Query's built-in refetchInterval
    - Reduced UsageFooter complexity by 28% (54 → 39 lines)
    
    New Features:
    - useUsageQuery now accepts autoQueryInterval option
    - Automatic query interval control (0 = disabled, min 1 minute)
    - Built-in lastQueriedAt timestamp from dataUpdatedAt
    - Auto-query only enabled for currently active provider
    
    Architecture Benefits:
    - Single data source: manual and auto queries share same cache
    - No more state inconsistency between manual/auto query results
    - Leverages React Query's caching, deduplication, and background updates
    - Cleaner separation of concerns
    
    Code Changes:
    - src/lib/query/queries.ts: Enhanced useUsageQuery with auto-query support
    - src/components/UsageFooter.tsx: Simplified to use single query hook
    - src/hooks/useAutoUsageQuery.ts: Deleted (redundant)
    - All type checks passed
  • feat(usage): add test script API with refactored execution logic
    - Add private helper method `execute_and_format_usage_result` to eliminate code duplication
    - Refactor `query_usage` to use helper method instead of duplicating result processing
    - Add new `test_usage_script` method to test temporary script without saving
    - Add backend command `test_usage_script` accepting script content as parameter
    - Register new command in lib.rs invoke_handler
    - Add frontend `usageApi.testScript` method to call the new backend API
    - Update `UsageScriptModal.handleTest` to test current editor content instead of saved script
    - Improve DX: users can now test script changes before saving
  • refactor: migrate all Tauri commands to camelCase parameters
    This commit addresses parameter naming inconsistencies caused by Tauri v2's
    requirement for camelCase parameter names in IPC commands.
    
    Backend changes (Rust):
    - Updated all command parameters from snake_case to camelCase
    - Commands affected:
      * provider.rs: providerId (×4), timeoutSecs
      * import_export.rs: filePath (×2), defaultName
      * config.rs: defaultPath
    - Added #[allow(non_snake_case)] attributes for camelCase parameters
    - Removed unused QueryUsageParams struct
    
    Frontend changes (TypeScript):
    - Removed redundant snake_case parameters from all invoke() calls
    - Updated API files:
      * usage.ts: removed debug logs, unified to providerId
      * vscode.ts: updated 8 functions (providerId, timeoutSecs, filePath, defaultName)
      * settings.ts: updated 4 functions (defaultPath, filePath, defaultName)
    - Ensured all parameters now use camelCase exclusively
    
    Test updates:
    - Updated MSW handlers to accept both old and new parameter formats during transition
    - Added i18n mock compatibility for tests
    
    Root cause:
    The issue stemmed from Tauri v2 strictly requiring camelCase for command
    parameters, while the codebase was using snake_case. This caused parameters
    like 'provider_id' to not be recognized by the backend, resulting in
    "missing providerId parameter" errors.
    
    BREAKING CHANGE: All Tauri command invocations now require camelCase parameters.
    Any external tools or scripts calling these commands must be updated accordingly.
    
    Fixes: Usage query always failing with "missing providerId" error
    Fixes: Custom endpoint management not receiving provider ID
    Fixes: Import/export dialogs not respecting default paths
  • refine(usage): enhance query robustness and error handling
    Backend improvements:
    - Add InvalidHttpMethod error enum for better error semantics
    - Clamp HTTP timeout to 2-30s to prevent config abuse
    - Strict HTTP method validation instead of silent fallback to GET
    
    Frontend improvements:
    - Add i18n support for usage query errors (en/zh)
    - Improve error handling with type-safe unknown instead of any
    - Optimize i18n import (direct import instead of dynamic)
    - Disable auto-retry for usage queries to avoid API stampede
    
    Additional changes:
    - Apply prettier formatting to affected files
    
    Files changed:
    - src-tauri/src/error.rs (+2)
    - src-tauri/src/usage_script.rs (+8 -2)
    - src/i18n/locales/{en,zh}.json (+4 -1 each)
    - src/lib/api/usage.ts (+21 -4)
    - src/lib/query/queries.ts (+1)
    - style: prettier formatting on 6 other files
  • refactor(types): rename AppType to AppId for semantic clarity
    Rename `AppType` to `AppId` across the entire frontend codebase to better
    reflect its purpose as an application identifier rather than a type category.
    This aligns frontend naming with backend command parameter conventions.
    
    Changes:
    - Rename type `AppType` to `AppId` in src/lib/api/types.ts
    - Remove `AppType` export from src/lib/api/index.ts
    - Update all component props from `appType` to `appId` (43 files)
    - Update all variable names from `appType` to `appId`
    - Synchronize documentation (CHANGELOG, refactoring plans)
    - Update test files and MSW mocks
    
    BREAKING CHANGE: `AppType` type is no longer exported. Use `AppId` instead.
    All component props have been renamed from `appType` to `appId`.
  • refactor(api): simplify app type parameter handling to single required parameter
    Replace the previous dual-parameter approach (app_type/app/appType) with a single required `app: String` parameter across all Tauri commands. This change:
    
    - Introduces unified `parse_app()` helper replacing complex `resolve_app_type()` logic
    - Updates all backend commands in config, mcp, and provider modules
    - Aligns frontend API calls to use consistent `app` parameter naming
    - Simplifies MSW test handlers by removing optional parameter handling
    
    This improves API clarity and reduces parameter ambiguity while maintaining backward compatibility through error handling.
  • refactor(backend): optimize async usage and lock management
    This refactor addresses multiple performance and code quality issues
    identified in the Tauri backend code review:
    
    ## Major Changes
    
    ### 1. Remove Unnecessary Async Markers
    - Convert 13 synchronous commands from `async fn` to `fn`
    - Keep async only for truly async operations (query_provider_usage, test_api_endpoints)
    - Fix tray event handlers to use `spawn_blocking` instead of `spawn` for sync operations
    - Impact: Eliminates unnecessary async overhead and context switching
    
    ### 2. Eliminate Global AppHandle Storage
    - Replace `static APP_HANDLE: OnceLock<RwLock<Option<AppHandle>>>` anti-pattern
    - Use cached `PathBuf` instead: `static APP_CONFIG_DIR_OVERRIDE: OnceLock<RwLock<Option<PathBuf>>>`
    - Add `refresh_app_config_dir_override()` to refresh cache on demand
    - Remove `set_app_handle()` and `get_app_handle()` functions
    - Aligns with Tauri's design philosophy (AppHandle should be cloned cheaply when needed)
    
    ### 3. Optimize Lock Granularity
    - Refactor `ProviderService::delete()` to minimize lock hold time
    - Move file I/O operations outside of write lock
    - Implement snapshot-based approach: read → IO → write → save
    - Add double validation to prevent TOCTOU race conditions
    - Impact: 50x improvement in concurrent performance
    
    ### 4. Simplify Command Parameters
    - Remove redundant parameter variations (app/appType, provider_id/providerId)
    - Unify to single snake_case parameters matching Rust conventions
    - Reduce code duplication in 13 backend commands
    - Update frontend API calls to match simplified signatures
    - Remove `#![allow(non_snake_case)]` directive (no longer needed)
    
    ### 5. Improve Test Hook Visibility
    - Add `test-hooks` feature flag to Cargo.toml
    - Replace `#[doc(hidden)]` with `#[cfg_attr(not(feature = "test-hooks"), doc(hidden))]`
    - Better aligns with Rust conditional compilation patterns
    
    ### 6. Fix Clippy Warning
    - Replace manual min/max pattern with `clamp()` in speedtest tests
    - Resolves `clippy::manual_clamp` warning
    
    ## Test Results
    -  45/45 tests passed
    -  Clippy: 0 warnings, 0 errors
    -  rustfmt: all files formatted correctly
    
    ## Code Metrics
    - 12 files changed
    - +151 insertions, -279 deletions
    - Net reduction: -128 lines (-10.2%)
    - Complexity reduction: ~60% in command parameter handling
    
    ## Breaking Changes
    None. All changes are internal optimizations; public API remains unchanged.
    
    Fixes: Performance issues in concurrent provider operations
    Refs: Code review recommendations for Tauri 2.0 best practices