From a17fa8098b3a67fa4dcb4ed40a8b236155f80da8 Mon Sep 17 00:00:00 2001
From: Jason <farion1231@gmail.com>
Date: Fri, 2 Jan 2026 22:33:33 +0800
Subject: [PATCH] fix(skills): remove redundant navigation buttons in skills
 pages

- Remove duplicate "Repo Manager" button from installed skills view
  (should only appear in discovery view)
- Remove redundant back button from SkillsPage component
  (header already provides unified navigation)
- Clean up unused openRepoManagerOnDiscovery state and related useEffect
- Remove unused onClose prop and ArrowLeft import from SkillsPage
---
 src/App.tsx                          | 22 ----------------------
 src/components/skills/SkillsPage.tsx | 20 ++------------------
 2 files changed, 2 insertions(+), 40 deletions(-)

diff --git a/src/App.tsx b/src/App.tsx
index 040cad238..21d8b0ad2 100644
--- a/src/App.tsx
+++ b/src/App.tsx
@@ -84,8 +84,6 @@ function App() {
   const promptPanelRef = useRef<any>(null);
   const mcpPanelRef = useRef<any>(null);
   const skillsPageRef = useRef<any>(null);
-  const [openRepoManagerOnDiscovery, setOpenRepoManagerOnDiscovery] =
-    useState(false);
   const addActionButtonClass =
     "bg-orange-500 hover:bg-orange-600 dark:bg-orange-500 dark:hover:bg-orange-600 text-white shadow-lg shadow-orange-500/30 dark:shadow-orange-500/40 rounded-full w-8 h-8";
 
@@ -122,13 +120,6 @@ function App() {
     }
   };
 
-  useEffect(() => {
-    if (currentView === "skillsDiscovery" && openRepoManagerOnDiscovery) {
-      skillsPageRef.current?.openRepoManager?.();
-      setOpenRepoManagerOnDiscovery(false);
-    }
-  }, [currentView, openRepoManagerOnDiscovery]);
-
   // 🎯 使用 useProviderActions Hook 统一管理所有 Provider 操作
   const {
     addProvider,
@@ -448,7 +439,6 @@ function App() {
           return (
             <SkillsPage
               ref={skillsPageRef}
-              onClose={() => setCurrentView("skills")}
               initialApp={activeApp}
             />
           );
@@ -685,18 +675,6 @@ function App() {
                   <Search className="w-4 h-4 mr-2" />
                   {t("skills.discover")}
                 </Button>
-                <Button
-                  variant="ghost"
-                  size="sm"
-                  onClick={() => {
-                    setOpenRepoManagerOnDiscovery(true);
-                    setCurrentView("skillsDiscovery");
-                  }}
-                  className="hover:bg-black/5 dark:hover:bg-white/5"
-                >
-                  <Settings className="w-4 h-4 mr-2" />
-                  {t("skills.repoManager")}
-                </Button>
               </>
             )}
             {currentView === "skillsDiscovery" && (
diff --git a/src/components/skills/SkillsPage.tsx b/src/components/skills/SkillsPage.tsx
index 9dc17117d..16bbce978 100644
--- a/src/components/skills/SkillsPage.tsx
+++ b/src/components/skills/SkillsPage.tsx
@@ -9,7 +9,7 @@ import {
   SelectTrigger,
   SelectValue,
 } from "@/components/ui/select";
-import { RefreshCw, Search, ArrowLeft } from "lucide-react";
+import { RefreshCw, Search } from "lucide-react";
 import { toast } from "sonner";
 import { SkillCard } from "./SkillCard";
 import { RepoManagerPanel } from "./RepoManagerPanel";
@@ -26,7 +26,6 @@ import type { DiscoverableSkill, SkillRepo } from "@/lib/api/skills";
 import { formatSkillError } from "@/lib/errors/skillErrorParser";
 
 interface SkillsPageProps {
-  onClose?: () => void;
   initialApp?: AppType;
 }
 
@@ -40,7 +39,7 @@ export interface SkillsPageHandle {
  * 用于浏览和安装来自仓库的 Skills
  */
 export const SkillsPage = forwardRef<SkillsPageHandle, SkillsPageProps>(
-  ({ onClose, initialApp = "claude" }, ref) => {
+  ({ initialApp = "claude" }, ref) => {
     const { t } = useTranslation();
     const [repoManagerOpen, setRepoManagerOpen] = useState(false);
     const [searchQuery, setSearchQuery] = useState("");
@@ -194,21 +193,6 @@ export const SkillsPage = forwardRef<SkillsPageHandle, SkillsPageProps>(
 
     return (
       <div className="mx-auto max-w-[56rem] px-6 flex flex-col h-[calc(100vh-8rem)] overflow-hidden bg-background/50">
-        {/* 返回按钮 */}
-        {onClose && (
-          <div className="flex-shrink-0 py-2">
-            <Button
-              variant="ghost"
-              size="sm"
-              onClick={onClose}
-              className="gap-2"
-            >
-              <ArrowLeft size={16} />
-              {t("common.back")}
-            </Button>
-          </div>
-        )}
-
         {/* 技能网格（可滚动详情区域） */}
         <div className="flex-1 overflow-y-auto overflow-x-hidden animate-fade-in">
           <div className="py-4">