mirror of
https://github.com/microsoft/agent-framework.git
synced 2026-06-16 21:04:09 +08:00
838a7fd61d
* Replace Role and FinishReason classes with NewType + Literal
- Remove EnumLike metaclass from _types.py
- Replace Role class with NewType('Role', str) + RoleLiteral
- Replace FinishReason class with NewType('FinishReason', str) + FinishReasonLiteral
- Update all usages across codebase to use string literals
- Remove .value access patterns (direct string comparison now works)
- Add backward compatibility for legacy dict serialization format
- Update tests to reflect new string-based types
Addresses #3591, #3615
* Simplify ChatResponse and AgentResponse type hints (#3592)
- Remove overloads from ChatResponse.__init__
- Remove text parameter from ChatResponse.__init__
- Remove | dict[str, Any] from finish_reason and usage_details params
- Remove **kwargs from AgentResponse.__init__
- Both now accept ChatMessage | Sequence[ChatMessage] | None for messages
- Update docstrings and examples to reflect changes
- Fix tests that were using removed kwargs
- Fix Role type hint usage in ag-ui utils
* Remove text parameter from ChatResponseUpdate and AgentResponseUpdate (#3597)
- Remove text parameter from ChatResponseUpdate.__init__
- Remove text parameter from AgentResponseUpdate.__init__
- Remove **kwargs from both update classes
- Simplify contents parameter type to Sequence[Content] | None
- Update all usages to use contents=[Content.from_text(...)] pattern
- Fix imports in test files
- Update docstrings and examples
* Rename from_chat_response_updates to from_updates (#3593)
- ChatResponse.from_chat_response_updates → ChatResponse.from_updates
- ChatResponse.from_chat_response_generator → ChatResponse.from_update_generator
- AgentResponse.from_agent_run_response_updates → AgentResponse.from_updates
* Remove try_parse_value method from ChatResponse and AgentResponse (#3595)
- Remove try_parse_value method from ChatResponse
- Remove try_parse_value method from AgentResponse
- Remove try_parse_value calls from from_updates and from_update_generator methods
- Update samples to use try/except with response.value instead
- Update tests to use response.value pattern
- Users should now use response.value with try/except for safe parsing
* Add agent_id to AgentResponse and clarify author_name documentation (#3596)
- Add agent_id parameter to AgentResponse class
- Document that author_name is on ChatMessage objects, not responses
- Update ChatResponse docstring with author_name note
- Update AgentResponse docstring with author_name note
* Simplify ChatMessage.__init__ signature (#3618)
- Make contents a positional argument accepting Sequence[Content | str]
- Auto-convert strings in contents to TextContent
- Remove overloads, keep text kwarg for backward compatibility with serialization
- Update _parse_content_list to handle string items
- Update all usages across codebase to use new format: ChatMessage("role", ["text"])
* Allow Content as input on run and get_response
- Update prepare_messages and normalize_messages to accept Content
- Update type signatures in _agents.py and _clients.py
- Add tests for Content input handling
* Fix ChatMessage usage across packages and samples
Update all remaining ChatMessage(role=..., text=...) to use new
ChatMessage('role', ['text']) signature.
* Fix Role string usage and response format parsing
- Fix redis provider: remove .value access on string literals
- Fix durabletask ensure_response_format: set _response_format before accessing .value
* Fix ollama .value and ai_model_id issues, handle None in content list
- Fix ollama _chat_client: remove .value on string literals
- Fix ollama _chat_client: rename ai_model_id to model_id
- Fix _parse_content_list: skip None values gracefully
* Fix A2AAgent type signature to include Content
* Fix Role/FinishReason NewType dict annotations and improve test coverage to 95%
* Fix mypy errors for Role/FinishReason NewType usage
* Fix Role.TOOL and Role.ASSISTANT usage in _orchestrator_helpers.py
* Fix Role NewType usage in durabletask _models.py
271 lines
9.7 KiB
Python
271 lines
9.7 KiB
Python
# Copyright (c) Microsoft. All rights reserved.
|
|
|
|
"""Tests for sliding window message list."""
|
|
|
|
from unittest.mock import patch
|
|
|
|
from agent_framework._types import ChatMessage, Content
|
|
from agent_framework_lab_tau2._sliding_window import SlidingWindowChatMessageStore
|
|
|
|
|
|
def test_initialization_empty():
|
|
"""Test initializing with no messages."""
|
|
sliding_window = SlidingWindowChatMessageStore(max_tokens=1000)
|
|
|
|
assert sliding_window.max_tokens == 1000
|
|
assert sliding_window.system_message is None
|
|
assert sliding_window.tool_definitions is None
|
|
assert len(sliding_window.messages) == 0
|
|
assert len(sliding_window.truncated_messages) == 0
|
|
|
|
|
|
def test_initialization_with_parameters():
|
|
"""Test initializing with system message and tool definitions."""
|
|
system_msg = "You are a helpful assistant"
|
|
tool_defs = [{"name": "test_tool", "description": "A test tool"}]
|
|
|
|
sliding_window = SlidingWindowChatMessageStore(
|
|
max_tokens=2000, system_message=system_msg, tool_definitions=tool_defs
|
|
)
|
|
|
|
assert sliding_window.max_tokens == 2000
|
|
assert sliding_window.system_message == system_msg
|
|
assert sliding_window.tool_definitions == tool_defs
|
|
|
|
|
|
def test_initialization_with_messages():
|
|
"""Test initializing with existing messages."""
|
|
messages = [
|
|
ChatMessage("user", [Content.from_text(text="Hello")]),
|
|
ChatMessage("assistant", [Content.from_text(text="Hi there!")]),
|
|
]
|
|
|
|
sliding_window = SlidingWindowChatMessageStore(messages=messages, max_tokens=1000)
|
|
|
|
assert len(sliding_window.messages) == 2
|
|
assert len(sliding_window.truncated_messages) == 2
|
|
|
|
|
|
async def test_add_messages_simple():
|
|
"""Test adding messages without truncation."""
|
|
sliding_window = SlidingWindowChatMessageStore(max_tokens=10000) # Large limit
|
|
|
|
new_messages = [
|
|
ChatMessage("user", [Content.from_text(text="What's the weather?")]),
|
|
ChatMessage("assistant", [Content.from_text(text="I can help with that.")]),
|
|
]
|
|
|
|
await sliding_window.add_messages(new_messages)
|
|
|
|
messages = await sliding_window.list_messages()
|
|
assert len(messages) == 2
|
|
assert messages[0].text == "What's the weather?"
|
|
assert messages[1].text == "I can help with that."
|
|
|
|
|
|
async def test_list_all_messages_vs_list_messages():
|
|
"""Test difference between list_all_messages and list_messages."""
|
|
sliding_window = SlidingWindowChatMessageStore(max_tokens=50) # Small limit to force truncation
|
|
|
|
# Add many messages to trigger truncation
|
|
messages = [ChatMessage("user", [Content.from_text(text=f"Message {i} with some content")]) for i in range(10)]
|
|
|
|
await sliding_window.add_messages(messages)
|
|
|
|
truncated_messages = await sliding_window.list_messages()
|
|
all_messages = await sliding_window.list_all_messages()
|
|
|
|
# All messages should contain everything
|
|
assert len(all_messages) == 10
|
|
|
|
# Truncated messages should be fewer due to token limit
|
|
assert len(truncated_messages) < len(all_messages)
|
|
|
|
|
|
def test_get_token_count_basic():
|
|
"""Test basic token counting."""
|
|
sliding_window = SlidingWindowChatMessageStore(max_tokens=1000)
|
|
sliding_window.truncated_messages = [ChatMessage("user", [Content.from_text(text="Hello")])]
|
|
|
|
token_count = sliding_window.get_token_count()
|
|
|
|
# Should be more than 0 (exact count depends on encoding)
|
|
assert token_count > 0
|
|
|
|
|
|
def test_get_token_count_with_system_message():
|
|
"""Test token counting includes system message."""
|
|
system_msg = "You are a helpful assistant"
|
|
sliding_window = SlidingWindowChatMessageStore(max_tokens=1000, system_message=system_msg)
|
|
|
|
# Without messages
|
|
token_count_empty = sliding_window.get_token_count()
|
|
|
|
# Add a message
|
|
sliding_window.truncated_messages = [ChatMessage("user", [Content.from_text(text="Hello")])]
|
|
token_count_with_message = sliding_window.get_token_count()
|
|
|
|
# With message should be more tokens
|
|
assert token_count_with_message > token_count_empty
|
|
assert token_count_empty > 0 # System message contributes tokens
|
|
|
|
|
|
def test_get_token_count_function_call():
|
|
"""Test token counting with function calls."""
|
|
function_call = Content.from_function_call(call_id="call_123", name="test_function", arguments={"param": "value"})
|
|
|
|
sliding_window = SlidingWindowChatMessageStore(max_tokens=1000)
|
|
sliding_window.truncated_messages = [ChatMessage("assistant", [function_call])]
|
|
|
|
token_count = sliding_window.get_token_count()
|
|
assert token_count > 0
|
|
|
|
|
|
def test_get_token_count_function_result():
|
|
"""Test token counting with function results."""
|
|
function_result = Content.from_function_result(call_id="call_123", result={"success": True, "data": "result"})
|
|
|
|
sliding_window = SlidingWindowChatMessageStore(max_tokens=1000)
|
|
sliding_window.truncated_messages = [ChatMessage("tool", [function_result])]
|
|
|
|
token_count = sliding_window.get_token_count()
|
|
assert token_count > 0
|
|
|
|
|
|
@patch("agent_framework_lab_tau2._sliding_window.logger")
|
|
def test_truncate_messages_removes_old_messages(mock_logger):
|
|
"""Test that truncation removes old messages when token limit exceeded."""
|
|
sliding_window = SlidingWindowChatMessageStore(max_tokens=20) # Very small limit
|
|
|
|
# Create messages that will exceed the limit
|
|
messages = [
|
|
ChatMessage(
|
|
role="user",
|
|
contents=[Content.from_text(text="This is a very long message that should exceed the token limit")],
|
|
),
|
|
ChatMessage(
|
|
role="assistant",
|
|
contents=[
|
|
Content.from_text(text="This is another very long message that should also exceed the token limit")
|
|
],
|
|
),
|
|
ChatMessage("user", [Content.from_text(text="Short msg")]),
|
|
]
|
|
|
|
sliding_window.truncated_messages = messages.copy()
|
|
sliding_window.truncate_messages()
|
|
|
|
# Should have fewer messages after truncation
|
|
assert len(sliding_window.truncated_messages) < len(messages)
|
|
|
|
# Should have logged warnings
|
|
assert mock_logger.warning.called
|
|
|
|
|
|
@patch("agent_framework_lab_tau2._sliding_window.logger")
|
|
def test_truncate_messages_removes_leading_tool_messages(mock_logger):
|
|
"""Test that truncation removes leading tool messages."""
|
|
sliding_window = SlidingWindowChatMessageStore(max_tokens=10000) # Large limit
|
|
|
|
# Create messages starting with tool message
|
|
tool_message = ChatMessage(
|
|
role="tool", contents=[Content.from_function_result(call_id="call_123", result="result")]
|
|
)
|
|
user_message = ChatMessage("user", [Content.from_text(text="Hello")])
|
|
|
|
sliding_window.truncated_messages = [tool_message, user_message]
|
|
sliding_window.truncate_messages()
|
|
|
|
# Tool message should be removed from the beginning
|
|
assert len(sliding_window.truncated_messages) == 1
|
|
assert sliding_window.truncated_messages[0].role == "user"
|
|
|
|
# Should have logged warning about removing tool message
|
|
mock_logger.warning.assert_called()
|
|
|
|
|
|
def test_estimate_any_object_token_count_dict():
|
|
"""Test token counting for dictionary objects."""
|
|
sliding_window = SlidingWindowChatMessageStore(max_tokens=1000)
|
|
|
|
test_dict = {"key": "value", "number": 42}
|
|
token_count = sliding_window.estimate_any_object_token_count(test_dict)
|
|
|
|
assert token_count > 0
|
|
|
|
|
|
def test_estimate_any_object_token_count_string():
|
|
"""Test token counting for string objects."""
|
|
sliding_window = SlidingWindowChatMessageStore(max_tokens=1000)
|
|
|
|
test_string = "This is a test string"
|
|
token_count = sliding_window.estimate_any_object_token_count(test_string)
|
|
|
|
assert token_count > 0
|
|
|
|
|
|
def test_estimate_any_object_token_count_non_serializable():
|
|
"""Test token counting for non-JSON-serializable objects."""
|
|
sliding_window = SlidingWindowChatMessageStore(max_tokens=1000)
|
|
|
|
# Create an object that can't be JSON serialized
|
|
class CustomObject:
|
|
def __str__(self):
|
|
return "CustomObject instance"
|
|
|
|
custom_obj = CustomObject()
|
|
token_count = sliding_window.estimate_any_object_token_count(custom_obj)
|
|
|
|
# Should fall back to string representation
|
|
assert token_count > 0
|
|
|
|
|
|
async def test_real_world_scenario():
|
|
"""Test a realistic conversation scenario."""
|
|
sliding_window = SlidingWindowChatMessageStore(
|
|
max_tokens=30,
|
|
system_message="You are a helpful assistant", # Moderate limit
|
|
)
|
|
|
|
# Simulate a conversation
|
|
conversation = [
|
|
ChatMessage("user", [Content.from_text(text="Hello, how are you?")]),
|
|
ChatMessage(
|
|
role="assistant",
|
|
contents=[Content.from_text(text="I'm doing well, thank you! How can I help you today?")],
|
|
),
|
|
ChatMessage("user", [Content.from_text(text="Can you tell me about the weather?")]),
|
|
ChatMessage(
|
|
role="assistant",
|
|
contents=[
|
|
Content.from_text(
|
|
text="I'd be happy to help with weather information, "
|
|
"but I don't have access to current weather data."
|
|
)
|
|
],
|
|
),
|
|
ChatMessage("user", [Content.from_text(text="What about telling me a joke instead?")]),
|
|
ChatMessage(
|
|
role="assistant",
|
|
contents=[
|
|
Content.from_text(text="Sure! Why don't scientists trust atoms? Because they make up everything!")
|
|
],
|
|
),
|
|
]
|
|
|
|
await sliding_window.add_messages(conversation)
|
|
|
|
current_messages = await sliding_window.list_messages()
|
|
all_messages = await sliding_window.list_all_messages()
|
|
|
|
# All messages should be preserved
|
|
assert len(all_messages) == 6
|
|
|
|
# Current messages might be truncated
|
|
assert len(current_messages) <= 6
|
|
|
|
# Token count should be within or close to limit
|
|
token_count = sliding_window.get_token_count()
|
|
# Allow some margin since truncation happens when exceeded
|
|
assert token_count <= sliding_window.max_tokens * 1.1
|