Evan Mattson c5ed8209df Python: Fix StandardMagenticManager to propagate session to manager agent (#4409) ...

* Fix #4371: Propagate session to manager agent in StandardMagenticManager

StandardMagenticManager._complete() was calling self._agent.run(messages)
without passing a session. This caused context providers (e.g.
RedisHistoryProvider) configured on the manager agent to silently fail,
as each call created a new ephemeral session with a different session_id.

Changes:
- Create an AgentSession in StandardMagenticManager.__init__()
- Pass session=self._session in _complete() calls to agent.run()
- Persist/restore the session in checkpoint save/restore methods
- Add regression tests for session propagation and checkpoint round-trip

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add type: ignore[reportPrivateUsage] to private attribute assertions in tests

Address PR review feedback: add # type: ignore[reportPrivateUsage] comments
to _session attribute accesses in the new regression tests, matching the
existing convention used elsewhere in test_magentic.py (e.g., lines 401-406).

The @pytest.mark.asyncio decorator is not needed because pyproject.toml
sets asyncio_mode = "auto".

Fixes #4371

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address review: use getattr for private _session access in tests (#4371)

Replace direct mgr._session access with getattr(mgr, "_session") to avoid
reportPrivateUsage type-checking warnings without needing type: ignore comments.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Apply pre-commit auto-fixes

* Address PR review: fix session restore guard and improve test robustness (#4371)

- Use 'is not None' instead of truthiness check for session_payload restore
- Use getattr() for private _session attribute access in tests
- Add backward-compatibility test for on_checkpoint_restore with empty state

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Make non-async tests plain def to avoid pytest-asyncio dependency (#4409)

Tests that never await anything don't need to be async. Using plain def
ensures they always run regardless of pytest-asyncio configuration.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Apply pre-commit auto-fixes

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

c5ed8209df · 2026-03-03 18:26:04 +00:00

History

..

test_concurrent.py

[BREAKING] Python: Checkpoint refactor: encode/decode, checkpoint format, etc (#3744)

2026-02-11 20:57:15 +00:00

test_group_chat.py

Python: [BREAKING] Fix #3613 chat/agent message typing alignment (#3920)

2026-02-16 15:27:25 +00:00

test_handoff.py

Python: Tighten HandoffBuilder to require Agent instead of SupportsAgentRun (#4301) (#4302)

2026-02-26 20:52:06 +00:00

test_magentic.py

Python: Fix StandardMagenticManager to propagate session to manager agent (#4409)

2026-03-03 18:26:04 +00:00

test_orchestration_request_info.py

Python: [BREAKING] PR2 — Wire context provider pipeline, remove old types, update all consumers (#3850)

2026-02-12 21:00:32 +00:00

test_sequential.py

Python: [BREAKING] PR2 — Wire context provider pipeline, remove old types, update all consumers (#3850)

2026-02-12 21:00:32 +00:00