mirror of https://github.com/microsoft/agent-framework.git synced 2026-06-16 21:04:09 +08:00

Files

T

Evan Mattson 4dc20c6be4 Python: Fix PowerFx eval crash on non-English system locales by setting CurrentUICulture to en-US (#4408 )

* Fix #4321: Set CurrentUICulture to en-US in PowerFx eval()

On non-English systems, CultureInfo.CurrentUICulture causes PowerFx to
emit localized error messages. The existing ValueError guard only matches
English strings ("isn't recognized", "Name isn't valid"), so undefined
variable errors crash instead of returning None gracefully.

Fix: save and restore CurrentUICulture alongside CurrentCulture before
calling engine.eval(), ensuring error messages are always in English.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Reuse single CultureInfo instance to avoid redundant allocations

Cache CultureInfo("en-US") in a local variable instead of instantiating
it twice per eval() call, as suggested in PR review.

Fixes #4321

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add assertion for CurrentUICulture restoration after eval

Assert that the production code's finally-block correctly restores
CurrentUICulture to it-IT after eval returns, covering future
regressions where the culture could leak.

The CultureInfo caching suggestion (comment #2) was already
implemented in the production code.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

4dc20c6be4 · 2026-03-04 05:46:16 +00:00

History

agent_framework_declarative

Python: Fix PowerFx eval crash on non-English system locales by setting CurrentUICulture to en-US (#4408 )

2026-03-04 05:46:16 +00:00

tests

Python: Fix PowerFx eval crash on non-English system locales by setting CurrentUICulture to en-US (#4408 )

2026-03-04 05:46:16 +00:00

AGENTS.md

Python: Fix code samples in AGENTS.md files that fail pre-commit checks (#3779 )

2026-02-10 07:15:36 +00:00

LICENSE

Python: Introducing support for declarative yaml spec (#2002 )

2025-11-19 16:33:02 +00:00

pyproject.toml

Update Python package versions to rc2 (#4258 )

2026-02-25 19:37:44 +00:00

README.md

Python: Introducing support for declarative yaml spec (#2002 )

2025-11-19 16:33:02 +00:00

README.md

Get Started with Microsoft Agent Framework Declarative

Please install this package via pip:

pip install agent-framework-declarative --pre

Declarative features

The declarative packages provides support for building agents based on a declarative yaml specification.