agent-framework

mirror of https://github.com/microsoft/agent-framework.git synced 2026-06-16 21:04:09 +08:00

Files

T

Evan Mattson 54c0bea3b6 Python: Fix agent option merge to support dict-defined tools (#4314 )

* Fix _merge_options dropping dict-defined tools (#4303)

_merge_options used getattr(tool, 'name', None) to de-duplicate tools,
which returns None for dict-style tool definitions. This caused all
override dict tools to be treated as duplicates of each other and of any
base dict tools, silently dropping them.

Add _get_tool_name() helper that extracts the name from both object-style
tools (via .name attribute) and dict-style tools (via tool['function']['name']).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address review: fix None dedup bug and add comprehensive tests (#4303)

- Exclude None from existing_names set so nameless/malformed tools are
  not silently deduplicated against each other
- Add test for cross-type dedup (dict tool + object tool with same name)
- Add test verifying nameless tools are preserved (not falsely deduped)
- Add unit tests for _get_tool_name edge cases: missing function key,
  non-dict function value, missing name, no name attribute, non-dict
  inputs, and valid dict/object tools

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

54c0bea3b6 · 2026-02-26 22:09:36 +00:00

History

azure

Python: updated integration tests and guidance (#4181 )

2026-02-24 09:35:46 +00:00

core

Python: Fix agent option merge to support dict-defined tools (#4314 )

2026-02-26 22:09:36 +00:00

openai

Python: Fix single-tool input handling in OpenAIResponsesClient._prepare_tools_for_openai (#4312 )

2026-02-26 22:09:28 +00:00

workflow