mirror of
https://github.com/microsoft/agent-framework.git
synced 2026-06-16 21:04:09 +08:00
a4b9539b62
* Python: clean up kwargs across agents, chat clients, tools, and sessions (#3642) Audit and refactor public **kwargs usage across core agents, chat clients, tools, sessions, and provider packages per the migration strategy codified in CODING_STANDARD.md. Key changes: - Add explicit runtime buckets: function_invocation_kwargs and client_kwargs on RawAgent.run() and chat client get_response() layers. - Refactor FunctionTool to prefer explicit ctx: FunctionInvocationContext injection; legacy **kwargs tools still work via _forward_runtime_kwargs. - Refactor Agent.as_tool() to use direct JSON schema, always-streaming wrapper, approval_mode parameter, and UserInputRequiredException propagation (integrates PR #4568 behavior). - Remove implicit session bleeding into FunctionInvocationContext; tools that need a session must receive it via function_invocation_kwargs. - Lower chat-client layers after FunctionInvocationLayer accept only compatibility **kwargs (client_kwargs flattened, function_invocation_kwargs ignored). - Add layered docstring composition from Raw... implementations via _docstrings.py helper. - Clean up provider constructors to use explicit additional_properties. - Deprecation warnings on legacy direct kwargs paths. - Update samples, tests, and typing across all 23 packages. Resolves #3642 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * clarified docstring * feedback fixes * Add unit tests for _docstrings.py build/apply helpers Tests cover: no docstring source, no extra kwargs, appending to existing Keyword Args section, inserting after Args, inserting in plain docstrings, multiline descriptions, ordering, and apply_layered_docstring. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add test for propagate_session TypeError on non-AgentSession values Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add tests for multi-content and empty UserInputRequiredException propagation Cover the branching logic in _try_execute_function_calls for: - Multiple user_input_request items in a single exception (extra_user_input_contents path) - Empty contents list (fallback function_result path) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add tests for DurableAIAgent.get_session forwarding service_session_id Verifies get_session correctly forwards service_session_id and session_id to the executor's get_new_session, replacing the removed kwargs test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Simplify ag-ui test stub to read session from client_kwargs only Remove dual-mode detection (client_kwargs vs raw kwargs fallback) from the test mock. Session is now read exclusively from client_kwargs, matching the settled public calling convention. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * updated create and get sessions in durable * fixed docstrings * fix test * updated session handling * updated from main * updated tests --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
88 lines
3.3 KiB
Python
88 lines
3.3 KiB
Python
# Copyright (c) Microsoft. All rights reserved.
|
|
|
|
"""Unit tests for DurableAIAgentOrchestrationContext.
|
|
|
|
Focuses on critical orchestration workflows: agent retrieval and integration.
|
|
Run with: pytest tests/test_orchestration_context.py -v
|
|
"""
|
|
|
|
from unittest.mock import Mock
|
|
|
|
import pytest
|
|
from agent_framework import SupportsAgentRun
|
|
|
|
from agent_framework_durabletask import DurableAgentSession
|
|
from agent_framework_durabletask._orchestration_context import DurableAIAgentOrchestrationContext
|
|
from agent_framework_durabletask._shim import DurableAIAgent
|
|
|
|
|
|
@pytest.fixture
|
|
def mock_orchestration_context() -> Mock:
|
|
"""Create a mock OrchestrationContext for testing."""
|
|
return Mock()
|
|
|
|
|
|
@pytest.fixture
|
|
def agent_context(mock_orchestration_context: Mock) -> DurableAIAgentOrchestrationContext:
|
|
"""Create a DurableAIAgentOrchestrationContext with mock context."""
|
|
return DurableAIAgentOrchestrationContext(mock_orchestration_context)
|
|
|
|
|
|
class TestDurableAIAgentOrchestrationContextGetAgent:
|
|
"""Test core workflow: retrieving agents from orchestration context."""
|
|
|
|
def test_get_agent_returns_durable_agent_shim(self, agent_context: DurableAIAgentOrchestrationContext) -> None:
|
|
"""Verify get_agent returns a DurableAIAgent instance."""
|
|
agent = agent_context.get_agent("assistant")
|
|
|
|
assert isinstance(agent, DurableAIAgent)
|
|
assert isinstance(agent, SupportsAgentRun)
|
|
|
|
def test_get_agent_shim_has_correct_name(self, agent_context: DurableAIAgentOrchestrationContext) -> None:
|
|
"""Verify retrieved agent has the correct name."""
|
|
agent = agent_context.get_agent("my_agent")
|
|
|
|
assert agent.name == "my_agent"
|
|
|
|
def test_get_agent_multiple_times_returns_new_instances(
|
|
self, agent_context: DurableAIAgentOrchestrationContext
|
|
) -> None:
|
|
"""Verify multiple get_agent calls return independent instances."""
|
|
agent1 = agent_context.get_agent("assistant")
|
|
agent2 = agent_context.get_agent("assistant")
|
|
|
|
assert agent1 is not agent2 # Different object instances
|
|
|
|
def test_get_agent_different_agents(self, agent_context: DurableAIAgentOrchestrationContext) -> None:
|
|
"""Verify context can retrieve multiple different agents."""
|
|
agent1 = agent_context.get_agent("agent1")
|
|
agent2 = agent_context.get_agent("agent2")
|
|
|
|
assert agent1.name == "agent1"
|
|
assert agent2.name == "agent2"
|
|
|
|
|
|
class TestDurableAIAgentOrchestrationContextIntegration:
|
|
"""Test integration scenarios between orchestration context and agent shim."""
|
|
|
|
def test_orchestration_agent_has_working_run_method(
|
|
self, agent_context: DurableAIAgentOrchestrationContext
|
|
) -> None:
|
|
"""Verify agent from context has callable run method (even if not yet implemented)."""
|
|
agent = agent_context.get_agent("assistant")
|
|
|
|
assert hasattr(agent, "run")
|
|
assert callable(agent.run)
|
|
|
|
def test_orchestration_agent_can_create_sessions(self, agent_context: DurableAIAgentOrchestrationContext) -> None:
|
|
"""Verify agent from context can create DurableAgentSession instances."""
|
|
agent = agent_context.get_agent("assistant")
|
|
|
|
session = agent.create_session()
|
|
|
|
assert isinstance(session, DurableAgentSession)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
pytest.main([__file__, "-v", "--tb=short"])
|