mirror of
https://github.com/microsoft/agent-framework.git
synced 2026-06-16 21:04:09 +08:00
Eduard van Valkenburg
838a7fd61d
* Replace Role and FinishReason classes with NewType + Literal
- Remove EnumLike metaclass from _types.py
- Replace Role class with NewType('Role', str) + RoleLiteral
- Replace FinishReason class with NewType('FinishReason', str) + FinishReasonLiteral
- Update all usages across codebase to use string literals
- Remove .value access patterns (direct string comparison now works)
- Add backward compatibility for legacy dict serialization format
- Update tests to reflect new string-based types
Addresses #3591, #3615
* Simplify ChatResponse and AgentResponse type hints (#3592)
- Remove overloads from ChatResponse.__init__
- Remove text parameter from ChatResponse.__init__
- Remove | dict[str, Any] from finish_reason and usage_details params
- Remove **kwargs from AgentResponse.__init__
- Both now accept ChatMessage | Sequence[ChatMessage] | None for messages
- Update docstrings and examples to reflect changes
- Fix tests that were using removed kwargs
- Fix Role type hint usage in ag-ui utils
* Remove text parameter from ChatResponseUpdate and AgentResponseUpdate (#3597)
- Remove text parameter from ChatResponseUpdate.__init__
- Remove text parameter from AgentResponseUpdate.__init__
- Remove **kwargs from both update classes
- Simplify contents parameter type to Sequence[Content] | None
- Update all usages to use contents=[Content.from_text(...)] pattern
- Fix imports in test files
- Update docstrings and examples
* Rename from_chat_response_updates to from_updates (#3593)
- ChatResponse.from_chat_response_updates → ChatResponse.from_updates
- ChatResponse.from_chat_response_generator → ChatResponse.from_update_generator
- AgentResponse.from_agent_run_response_updates → AgentResponse.from_updates
* Remove try_parse_value method from ChatResponse and AgentResponse (#3595)
- Remove try_parse_value method from ChatResponse
- Remove try_parse_value method from AgentResponse
- Remove try_parse_value calls from from_updates and from_update_generator methods
- Update samples to use try/except with response.value instead
- Update tests to use response.value pattern
- Users should now use response.value with try/except for safe parsing
* Add agent_id to AgentResponse and clarify author_name documentation (#3596)
- Add agent_id parameter to AgentResponse class
- Document that author_name is on ChatMessage objects, not responses
- Update ChatResponse docstring with author_name note
- Update AgentResponse docstring with author_name note
* Simplify ChatMessage.__init__ signature (#3618)
- Make contents a positional argument accepting Sequence[Content | str]
- Auto-convert strings in contents to TextContent
- Remove overloads, keep text kwarg for backward compatibility with serialization
- Update _parse_content_list to handle string items
- Update all usages across codebase to use new format: ChatMessage("role", ["text"])
* Allow Content as input on run and get_response
- Update prepare_messages and normalize_messages to accept Content
- Update type signatures in _agents.py and _clients.py
- Add tests for Content input handling
* Fix ChatMessage usage across packages and samples
Update all remaining ChatMessage(role=..., text=...) to use new
ChatMessage('role', ['text']) signature.
* Fix Role string usage and response format parsing
- Fix redis provider: remove .value access on string literals
- Fix durabletask ensure_response_format: set _response_format before accessing .value
* Fix ollama .value and ai_model_id issues, handle None in content list
- Fix ollama _chat_client: remove .value on string literals
- Fix ollama _chat_client: rename ai_model_id to model_id
- Fix _parse_content_list: skip None values gracefully
* Fix A2AAgent type signature to include Content
* Fix Role/FinishReason NewType dict annotations and improve test coverage to 95%
* Fix mypy errors for Role/FinishReason NewType usage
* Fix Role.TOOL and Role.ASSISTANT usage in _orchestrator_helpers.py
* Fix Role NewType usage in durabletask _models.py
144 lines
5.2 KiB
Python
144 lines
5.2 KiB
Python
# Copyright (c) Microsoft. All rights reserved.
|
|
|
|
"""Tests for Agent Framework to ChatKit streaming utilities."""
|
|
|
|
from unittest.mock import Mock
|
|
|
|
from agent_framework import AgentResponseUpdate, Content
|
|
from chatkit.types import (
|
|
ThreadItemAddedEvent,
|
|
ThreadItemDoneEvent,
|
|
ThreadItemUpdated,
|
|
)
|
|
|
|
from agent_framework_chatkit import stream_agent_response
|
|
|
|
|
|
class TestStreamAgentResponse:
|
|
"""Tests for stream_agent_response function."""
|
|
|
|
async def test_stream_empty_response(self):
|
|
"""Test streaming empty response."""
|
|
|
|
async def empty_stream():
|
|
return
|
|
yield # Make it a generator
|
|
|
|
events = []
|
|
async for event in stream_agent_response(empty_stream(), thread_id="test_thread"):
|
|
events.append(event)
|
|
|
|
assert len(events) == 0
|
|
|
|
async def test_stream_single_text_update(self):
|
|
"""Test streaming single text update."""
|
|
|
|
async def single_update_stream():
|
|
yield AgentResponseUpdate(role="assistant", contents=[Content.from_text(text="Hello world")])
|
|
|
|
events = []
|
|
async for event in stream_agent_response(single_update_stream(), thread_id="test_thread"):
|
|
events.append(event)
|
|
|
|
# Should have: item_added, item_updated (delta), item_done
|
|
assert len(events) == 3
|
|
|
|
# Check event types
|
|
assert isinstance(events[0], ThreadItemAddedEvent)
|
|
assert isinstance(events[1], ThreadItemUpdated)
|
|
assert isinstance(events[2], ThreadItemDoneEvent)
|
|
|
|
# Check delta event
|
|
assert events[1].update.delta == "Hello world"
|
|
|
|
# Check final message content
|
|
assert len(events[2].item.content) == 1
|
|
assert events[2].item.content[0].text == "Hello world"
|
|
|
|
async def test_stream_multiple_text_updates(self):
|
|
"""Test streaming multiple text updates."""
|
|
|
|
async def multiple_updates_stream():
|
|
yield AgentResponseUpdate(role="assistant", contents=[Content.from_text(text="Hello ")])
|
|
yield AgentResponseUpdate(role="assistant", contents=[Content.from_text(text="world!")])
|
|
|
|
events = []
|
|
async for event in stream_agent_response(multiple_updates_stream(), thread_id="test_thread"):
|
|
events.append(event)
|
|
|
|
# Should have: item_added, item_updated (delta 1), item_updated (delta 2), item_done
|
|
assert len(events) == 4
|
|
|
|
# Check event types
|
|
assert isinstance(events[0], ThreadItemAddedEvent)
|
|
assert isinstance(events[1], ThreadItemUpdated)
|
|
assert isinstance(events[2], ThreadItemUpdated)
|
|
assert isinstance(events[3], ThreadItemDoneEvent)
|
|
|
|
# Check delta events
|
|
assert events[1].update.delta == "Hello "
|
|
assert events[2].update.delta == "world!"
|
|
|
|
# Check final accumulated text
|
|
final_message_event = events[-1]
|
|
assert isinstance(final_message_event, ThreadItemDoneEvent)
|
|
assert final_message_event.item.content[0].text == "Hello world!"
|
|
|
|
async def test_stream_with_custom_id_generator(self):
|
|
"""Test streaming with custom ID generator."""
|
|
|
|
def custom_id_generator(item_type: str) -> str:
|
|
return f"custom_{item_type}_123"
|
|
|
|
async def single_update_stream():
|
|
yield AgentResponseUpdate(role="assistant", contents=[Content.from_text(text="Test")])
|
|
|
|
events = []
|
|
async for event in stream_agent_response(
|
|
single_update_stream(), thread_id="test_thread", generate_id=custom_id_generator
|
|
):
|
|
events.append(event)
|
|
|
|
# Check that custom IDs are used
|
|
message_added_event = events[0]
|
|
assert message_added_event.item.id == "custom_msg_123"
|
|
|
|
async def test_stream_empty_content_updates(self):
|
|
"""Test streaming updates with empty content."""
|
|
|
|
async def empty_content_stream():
|
|
yield AgentResponseUpdate(role="assistant", contents=[])
|
|
yield AgentResponseUpdate(role="assistant", contents=None)
|
|
|
|
events = []
|
|
async for event in stream_agent_response(empty_content_stream(), thread_id="test_thread"):
|
|
events.append(event)
|
|
|
|
# Should have item_added and item_done
|
|
assert len(events) == 2
|
|
assert isinstance(events[0], ThreadItemAddedEvent)
|
|
assert isinstance(events[1], ThreadItemDoneEvent)
|
|
|
|
# Final message should have empty content
|
|
assert len(events[1].item.content) == 0
|
|
|
|
async def test_stream_non_text_content(self):
|
|
"""Test streaming updates with non-text content."""
|
|
# Mock a content object without text attribute
|
|
non_text_content = Mock(spec=Content)
|
|
non_text_content.type = "image"
|
|
# Don't set text attribute
|
|
non_text_content.text = None
|
|
|
|
async def non_text_stream():
|
|
yield AgentResponseUpdate(role="assistant", contents=[non_text_content])
|
|
|
|
events = []
|
|
async for event in stream_agent_response(non_text_stream(), thread_id="test_thread"):
|
|
events.append(event)
|
|
|
|
# Should have item_added and item_done, but no content since no text
|
|
assert len(events) == 2
|
|
assert isinstance(events[0], ThreadItemAddedEvent)
|
|
assert isinstance(events[1], ThreadItemDoneEvent)
|