mirror of
https://github.com/microsoft/agent-framework.git
synced 2026-06-16 21:04:09 +08:00
ad95f2f2fa
* .NET: Add Hosted-MemoryAgent sample with isolation key plumbing (#5692) Adds HostedSessionContext + HostedSessionIsolationKeyProvider in Microsoft.Agents.AI.Foundry.Hosting so AIContextProviders (notably FoundryMemoryProvider) can scope per user via the platform's x-agent-user-isolation-key / x-agent-chat-isolation-key headers. - New types: HostedSessionContext (sealed), HostedSessionContextExtensions (public Get, internal Set), abstract HostedSessionIsolationKeyProvider (async), internal PlatformHostedSessionIsolationKeyProvider mapping ResponseContext.Isolation. - AgentFrameworkResponseHandler now resolves the provider, tags fresh sessions, and validates resumed sessions against the live request (strict 403 'Hosted session identity context mismatch' on any mismatch; 500 on null keys). - New shared sample project Hosted_Shared_Contributor_Setup hosts DevTemporaryTokenCredential and DevTemporaryLocalSessionIsolationKeyProvider plus AddDevTemporaryLocalContributorSetup. All 9 existing responses samples migrated to consume it so local runs keep working under the strict isolation contract. - New Hosted-MemoryAgent sample: travel assistant wired through FoundryMemoryProvider with stateInitializer reading session.GetHostedContext().UserId. Includes Dockerfile, smoke.ps1, agent.yaml/manifest. - New IT scenario 'memory' in Foundry.Hosting.IntegrationTests + MemoryHostedAgentFixture + MemoryHostedAgentTests. Verified end to end against the tao Foundry project. - ADR 0026 captures the design tree. * Address PR review feedback - Dockerfile: add header noting it targets NuGet builds; contributors must use Dockerfile.contributor for ProjectReference source builds. - PlatformHostedSessionIsolationKeyProvider: doc said 'returns context with empty values'; corrected to 'returns null' which the handler treats as 500. - FakeHostedSessionIsolationKeyProvider: doc clarifies that null configurations are allowed for testing the handler error path. - HostedSessionContextExtensions.SetHostedContext: enforce write-once with InvalidOperationException; doc + xml exception updated. - AgentFrameworkResponseHandler: cache PlatformHostedSessionIsolationKeyProvider as static readonly to avoid per-request allocation. - MemoryHostedAgentTests: tighten waits from 20s to 5s (FoundryMemoryProvider defaults UpdateDelay=0; ingestion ~3s). - Sample Program.cs imports reordered to satisfy IDE0005. * Add HostedFoundryMemoryProviderScopes built-in helpers (#5692) Addresses review feedback from @lokitoth on Hosted-MemoryAgent/Program.cs:54. - New HostedFoundryMemoryProviderScopes static class with PerUser, PerChat, PerUserAndChat factories returning Func<AgentSession?, FoundryMemoryProvider.State>. - All helpers throw InvalidOperationException when GetHostedContext() is null, with a message pointing at writing a custom stateInitializer for non-hosted scenarios. - New HostedFoundryMemoryScope enum and AddHostedFoundryMemoryProvider DI extension (two overloads: explicit AIProjectClient and DI-resolved). Singleton lifetime. Default scope = PerUser. - Hosted-MemoryAgent sample and the memory IT scenario container both swap their inline lambdas for HostedFoundryMemoryProviderScopes.PerUser(). - 14 new unit tests (241/241 hosting unit tests pass). * Replace HostedFoundryMemoryScope enum with Func<...> parameter (#5692) Address PR review feedback from @westey-m: enums are a breaking-change hazard when extended, and the enum was redundant with the existing HostedFoundryMemoryProviderScopes static class. - Delete HostedFoundryMemoryScope.cs. - AddHostedFoundryMemoryProvider DI extensions now take Func<AgentSession?, FoundryMemoryProvider.State>? stateInitializer = null. When null, default to HostedFoundryMemoryProviderScopes.PerUser(). - Callers pick a built-in helper (PerUser/PerChat/PerUserAndChat) or pass a custom delegate. New built-ins are a single static method addition with zero impact on existing callers. - Tests updated; 244/244 hosting unit tests pass. * Fix isolation context resume for externally-created conversations (#5692) Branch on the session's existing hosted-context (not on conversation_id presence) so a conversation provisioned externally (e.g. via conversations.CreateProjectConversationAsync) is treated as fresh on first hosted-agent request and stamped, rather than rejected with 403 hosted_session_identity_mismatch. Strict equality is preserved on real resume of an already-stamped session. Also tighten dotnet/global.json to version 10.0.204 + rollForward latestPatch so local builds match the CI Docker image SDK and avoid 10.0.300 dotnet format stripping required usings. * Revert global.json SDK pin to upstream (#5692) The 10.0.204 + latestPatch pin from the previous commit broke the dotnet-format CI job (hostfxr_resolve_sdk2 could not find a compatible SDK in the mcr.microsoft.com/dotnet/sdk:10.0 image). Restore upstream 10.0.200 + minor; local Release builds with SDK 10.0.300 should set GITHUB_ACTIONS=true to bypass the auto-format-on-build target.
215 lines
9.2 KiB
C#
215 lines
9.2 KiB
C#
// Copyright (c) Microsoft. All rights reserved.
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using Azure.AI.AgentServer.Responses;
|
|
using Azure.AI.AgentServer.Responses.Models;
|
|
using Microsoft.Agents.AI.Workflows;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using Microsoft.Extensions.Logging;
|
|
using Microsoft.Extensions.Logging.Abstractions;
|
|
using Moq;
|
|
|
|
namespace Microsoft.Agents.AI.Foundry.Hosting.UnitTests;
|
|
|
|
/// <summary>
|
|
/// Unit tests for <see cref="AgentFrameworkResponseHandler"/> that verify behavior
|
|
/// when the registered agent is a workflow-backed <see cref="AIAgent"/>. These exercise
|
|
/// real workflow builders and the in-process execution environment to drive the handler
|
|
/// through realistic streaming event patterns.
|
|
/// </summary>
|
|
public class AgentFrameworkResponseHandlerWorkflowTests
|
|
{
|
|
[Fact]
|
|
public async Task SequentialWorkflow_SingleAgent_ProducesTextOutputAsync()
|
|
{
|
|
// Arrange: single-agent sequential workflow
|
|
var echoAgent = new StreamingTextAgent("echo", "Hello from the workflow!");
|
|
var workflow = AgentWorkflowBuilder.BuildSequential("test-sequential", echoAgent);
|
|
var workflowAgent = workflow.AsAIAgent(
|
|
id: "workflow-agent",
|
|
name: "Test Workflow",
|
|
executionEnvironment: InProcessExecution.OffThread,
|
|
includeExceptionDetails: true);
|
|
|
|
var (handler, request, context) = CreateHandlerWithAgent(workflowAgent, "Hello");
|
|
|
|
// Act
|
|
var events = await CollectEventsAsync(handler, request, context);
|
|
|
|
// Assert: should have lifecycle events + at least one text output + terminal
|
|
Assert.IsType<ResponseCreatedEvent>(events[0]);
|
|
Assert.IsType<ResponseInProgressEvent>(events[1]);
|
|
Assert.True(events.Count >= 4, $"Expected at least 4 events, got {events.Count}");
|
|
|
|
var lastEvent = events[^1];
|
|
Assert.True(
|
|
lastEvent is ResponseCompletedEvent || lastEvent is ResponseFailedEvent,
|
|
$"Expected terminal event, got {lastEvent.GetType().Name}");
|
|
}
|
|
|
|
[Fact]
|
|
public async Task SequentialWorkflow_TwoAgents_ProducesOutputFromBothAsync()
|
|
{
|
|
// Arrange: two agents in sequence
|
|
var agent1 = new StreamingTextAgent("agent1", "First agent says hello");
|
|
var agent2 = new StreamingTextAgent("agent2", "Second agent says goodbye");
|
|
var workflow = AgentWorkflowBuilder.BuildSequential("test-sequential-2", agent1, agent2);
|
|
var workflowAgent = workflow.AsAIAgent(
|
|
id: "seq-workflow",
|
|
name: "Sequential Workflow",
|
|
executionEnvironment: InProcessExecution.OffThread,
|
|
includeExceptionDetails: true);
|
|
|
|
var (handler, request, context) = CreateHandlerWithAgent(workflowAgent, "Process this");
|
|
|
|
// Act
|
|
var events = await CollectEventsAsync(handler, request, context);
|
|
|
|
// Assert: should have workflow action events for executor lifecycle
|
|
var lastEvent = events[^1];
|
|
Assert.True(
|
|
lastEvent is ResponseCompletedEvent || lastEvent is ResponseFailedEvent,
|
|
$"Expected terminal event, got {lastEvent.GetType().Name}");
|
|
|
|
// Should have output item events (either text messages or workflow actions)
|
|
Assert.True(events.OfType<ResponseOutputItemAddedEvent>().Any(),
|
|
"Expected at least one output item from the workflow");
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Workflow_AgentThrowsException_ProducesErrorOutputAsync()
|
|
{
|
|
// Arrange: workflow with an agent that throws
|
|
var throwingAgent = new ThrowingStreamingAgent("thrower", new InvalidOperationException("Agent crashed"));
|
|
var workflow = AgentWorkflowBuilder.BuildSequential("test-error", throwingAgent);
|
|
var workflowAgent = workflow.AsAIAgent(
|
|
id: "error-workflow",
|
|
name: "Error Workflow",
|
|
executionEnvironment: InProcessExecution.OffThread,
|
|
includeExceptionDetails: true);
|
|
|
|
var (handler, request, context) = CreateHandlerWithAgent(workflowAgent, "Trigger error");
|
|
|
|
// Act
|
|
var events = await CollectEventsAsync(handler, request, context);
|
|
|
|
// Assert: should have lifecycle events + error/failure indicator
|
|
Assert.IsType<ResponseCreatedEvent>(events[0]);
|
|
Assert.IsType<ResponseInProgressEvent>(events[1]);
|
|
|
|
var lastEvent = events[^1];
|
|
// Workflow errors surface as either Failed or Completed (depending on error handling)
|
|
Assert.True(
|
|
lastEvent is ResponseCompletedEvent || lastEvent is ResponseFailedEvent,
|
|
$"Expected terminal event, got {lastEvent.GetType().Name}");
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Workflow_ExecutorEvents_ProduceWorkflowActionItemsAsync()
|
|
{
|
|
// Arrange
|
|
var agent = new StreamingTextAgent("test-agent", "Result");
|
|
var workflow = AgentWorkflowBuilder.BuildSequential("test-actions", agent);
|
|
var workflowAgent = workflow.AsAIAgent(
|
|
id: "actions-workflow",
|
|
name: "Actions Workflow",
|
|
executionEnvironment: InProcessExecution.OffThread);
|
|
|
|
var (handler, request, context) = CreateHandlerWithAgent(workflowAgent, "Hello");
|
|
|
|
// Act
|
|
var events = await CollectEventsAsync(handler, request, context);
|
|
|
|
// Assert: workflow should produce OutputItemAdded events for executor lifecycle
|
|
var addedEvents = events.OfType<ResponseOutputItemAddedEvent>().ToList();
|
|
Assert.True(addedEvents.Count >= 1,
|
|
$"Expected at least 1 output item added event, got {addedEvents.Count}");
|
|
}
|
|
|
|
[Fact]
|
|
public async Task WorkflowAgent_RegisteredWithKey_ResolvesCorrectlyAsync()
|
|
{
|
|
// Arrange: workflow agent registered with a keyed service name
|
|
var agent = new StreamingTextAgent("inner", "Keyed workflow response");
|
|
var workflow = AgentWorkflowBuilder.BuildSequential("keyed-wf", agent);
|
|
var workflowAgent = workflow.AsAIAgent(
|
|
id: "keyed-workflow",
|
|
name: "Keyed Workflow",
|
|
executionEnvironment: InProcessExecution.OffThread);
|
|
|
|
var services = new ServiceCollection();
|
|
services.AddSingleton<AgentSessionStore>(new InMemoryAgentSessionStore());
|
|
services.AddKeyedSingleton("my-workflow", workflowAgent);
|
|
services.AddSingleton<HostedSessionIsolationKeyProvider>(new FakeHostedSessionIsolationKeyProvider());
|
|
var sp = services.BuildServiceProvider();
|
|
|
|
var handler = new AgentFrameworkResponseHandler(sp, NullLogger<AgentFrameworkResponseHandler>.Instance);
|
|
var request = new CreateResponse { Model = "test", AgentReference = new AgentReference("my-workflow") };
|
|
request.Input = CreateUserInput("Test keyed workflow");
|
|
var mockContext = CreateMockContext();
|
|
|
|
// Act
|
|
var events = await CollectEventsAsync(handler, request, mockContext.Object);
|
|
|
|
// Assert
|
|
Assert.IsType<ResponseCreatedEvent>(events[0]);
|
|
Assert.True(events.Count >= 3, $"Expected at least 3 events, got {events.Count}");
|
|
}
|
|
|
|
private static (AgentFrameworkResponseHandler handler, CreateResponse request, ResponseContext context)
|
|
CreateHandlerWithAgent(AIAgent agent, string userMessage)
|
|
{
|
|
var services = new ServiceCollection();
|
|
services.AddSingleton<AgentSessionStore>(new InMemoryAgentSessionStore());
|
|
services.AddSingleton(agent);
|
|
services.AddSingleton<ILogger<AgentFrameworkResponseHandler>>(NullLogger<AgentFrameworkResponseHandler>.Instance);
|
|
services.AddSingleton<HostedSessionIsolationKeyProvider>(new FakeHostedSessionIsolationKeyProvider());
|
|
var sp = services.BuildServiceProvider();
|
|
|
|
var handler = new AgentFrameworkResponseHandler(sp, NullLogger<AgentFrameworkResponseHandler>.Instance);
|
|
var request = new CreateResponse { Model = "test" };
|
|
request.Input = CreateUserInput(userMessage);
|
|
var mockContext = CreateMockContext();
|
|
|
|
return (handler, request, mockContext.Object);
|
|
}
|
|
|
|
private static BinaryData CreateUserInput(string text)
|
|
{
|
|
return BinaryData.FromObjectAsJson(new[]
|
|
{
|
|
new { type = "message", id = "msg_in_1", status = "completed", role = "user",
|
|
content = new[] { new { type = "input_text", text } }
|
|
}
|
|
});
|
|
}
|
|
|
|
private static Mock<ResponseContext> CreateMockContext()
|
|
{
|
|
var mock = new Mock<ResponseContext>("resp_" + new string('0', 46)) { CallBase = true };
|
|
mock.Setup(x => x.GetHistoryAsync(It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(Array.Empty<OutputItem>());
|
|
mock.Setup(x => x.GetInputItemsAsync(It.IsAny<bool>(), It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(Array.Empty<Item>());
|
|
return mock;
|
|
}
|
|
|
|
private static async Task<List<ResponseStreamEvent>> CollectEventsAsync(
|
|
AgentFrameworkResponseHandler handler,
|
|
CreateResponse request,
|
|
ResponseContext context)
|
|
{
|
|
var events = new List<ResponseStreamEvent>();
|
|
await foreach (var evt in handler.CreateAsync(request, context, CancellationToken.None))
|
|
{
|
|
events.Add(evt);
|
|
}
|
|
|
|
return events;
|
|
}
|
|
}
|