2 Commits

• Merge and move scripts (#4308)

  * .NET: Add Microsoft Fabric sample #3674 (#4230)
  
  Co-authored-by: Chris <66376200+crickman@users.noreply.github.com>
  
  * Python: Phase 2: Embedding clients for Ollama, Bedrock, and Azure AI Inference (#4207)
  
  * Phase 2: Embedding clients for Ollama, Bedrock, and Azure AI Inference
  
  Add embedding client implementations to existing provider packages:
  
  - OllamaEmbeddingClient: Text embeddings via Ollama's embed API
  - BedrockEmbeddingClient: Text embeddings via Amazon Titan on Bedrock
  - AzureAIInferenceEmbeddingClient: Text and image embeddings via Azure AI
    Inference, supporting Content | str input with separate model IDs for
    text (AZURE_AI_INFERENCE_EMBEDDING_MODEL_ID) and image
    (AZURE_AI_INFERENCE_IMAGE_EMBEDDING_MODEL_ID) endpoints
  
  Additional changes:
  - Rename EmbeddingCoT -> EmbeddingT, EmbeddingOptionsCoT -> EmbeddingOptionsT
  - Add otel_provider_name passthrough to all embedding clients
  - Register integration pytest marker in all packages
  - Add lazy-loading namespace exports for Ollama and Bedrock embeddings
  - Add image embedding sample using Cohere-embed-v3-english
  - Add azure-ai-inference dependency to azure-ai package
  
  Part of #1188
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Fix mypy duplicate name and ruff lint issues
  
  - Rename second 'vector' variable to 'img_vector' in image embedding loop
  - Combine nested with statements in tests
  - Remove unused result assignments in tests
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * updates from feedback
  
  * Fix CI failures in embedding usage handling
  
  - Fix Azure AI embedding mypy issues by normalizing vectors to list[float],
    safely accumulating optional usage token fields, and filtering None entries
    before constructing GeneratedEmbeddings
  - Avoid Bandit false positive by initializing usage details as an empty dict
  - Update OpenAI embedding tests to assert canonical usage keys
    (input_token_count/total_token_count)
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  ---------
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * [Purview] Mark responses as responses and fix epoch bug for python long overflow (#4225)
  
  * .NET: Support InvokeMcpTool for declarative workflows (#4204)
  
  * Initial implementation of InvokeMcpTool in declarative workflow
  
  * Cleaned up sample implementation
  
  * Updated sample comments.
  
  * Added missing executor routing attribute
  
  * Fix PR comments.
  
  * Updated based on PR comments.
  
  * Updated based on PR comments.
  
  * Removed unnecessary using statement.
  
  * Update Python package versions to rc2 (#4258)
  
  - Bump core and azure-ai to 1.0.0rc2
  - Bump preview packages to 1.0.0b260225
  - Update dependencies to >=1.0.0rc2
  - Add CHANGELOG entries for changes since rc1
  - Update uv.lock
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * .NET: Fixing issue where OpenTelemetry span is never exported in .NET in-process workflow execution (#4196)
  
  * 1. Add reproduction test for issue #4155: workflow.run Activity never stopped in streaming OffThread path
  
  The WorkflowRunActivity_IsStopped_Streaming_OffThread test demonstrates that
  the workflow.run OpenTelemetry Activity created in StreamingRunEventStream.RunLoopAsync
  is started but never stopped when using the OffThread/Default streaming execution.
  The background run loop keeps running after event consumption completes, so the
  using Activity? declaration never disposes until explicit StopAsync() is called.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  2. Fix workflow.run Activity never stopped in streaming OffThread execution (#4155)
  
  The workflow.run OpenTelemetry Activity in StreamingRunEventStream.RunLoopAsync
  was scoped to the method lifetime via 'using'. Since the run loop only exits on
  cancellation, the Activity was never stopped/exported until explicit disposal.
  
  Fix: Remove 'using' and explicitly dispose the Activity when the workflow reaches
  Idle status (all supersteps complete). A safety-net disposal in the finally block
  handles cancellation and error paths.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Add root-level workflow.session activity spanning run loop lifetime\n\nImplements two-level telemetry hierarchy per PR feedback from lokitoth:\n- workflow.session: spans the entire run loop / stream lifetime\n- workflow_invoke: per input-to-halt cycle, nested within the session\n\nThis ensures the session activity stays open across multiple turns,\nwhile individual run activities are created and disposed per cycle.\n\nAlso fixes linkedSource CancellationTokenSource disposal leak in\nStreamingRunEventStream (added using declaration)."
  
  * Address Copilot review: fix Activity/CTS disposal, rename activity, add error tag\n\n1. LockstepRunEventStream: Remove 'using' from Activity in async iterator\n   and manually dispose in finally block (fixes #4155 pattern). Also dispose\n   linkedSource CTS in finally to prevent leak.\n2. Tags.cs: Add ErrorMessage (\"error.message\") tag for runtime errors,\n   distinct from BuildErrorMessage (\"build.error.message\").\n3. ActivityNames: Rename WorkflowRun from \"workflow_invoke\" to \"workflow.run\"\n   for cross-language consistency.\n4. WorkflowTelemetryContext: Fix XML doc to say \"outer/parent span\" instead\n   of \"root-level span\".\n5. ObservabilityTests: Assert WorkflowSession absence when DisableWorkflowRun\n   is true.\n6. WorkflowRunActivityStopTests: Fix streaming test race by disposing\n   StreamingRun before asserting activities are stopped.\n7. StreamingRunEventStream/LockstepRunEventStream: Use Tags.ErrorMessage\n   instead of Tags.BuildErrorMessage for runtime error events."
  
  * Review fixes: revert workflow_invoke rename, use 'using' for linkedSource, move SessionStarted earlier\n\n- Revert ActivityNames.WorkflowRun back to \"workflow_invoke\" (OTEL semantic convention contract)\n- Use 'using' declaration for linkedSource CTS in LockstepRunEventStream (no timing sensitivity)\n- Move SessionStarted event before WaitForInputAsync in StreamingRunEventStream to match Lockstep behavior"
  
  * Improve naming and comments in WorkflowRunActivityStopTests"
  
  * Prevent session Activity.Current leak in lockstep mode, add nesting test
  
  Save and restore Activity.Current in LockstepRunEventStream.Start() so the
  session activity doesn't leak into caller code via AsyncLocal. Re-establish
  Activity.Current = sessionActivity before creating the run activity in
  TakeEventStreamAsync to preserve parent-child nesting.
  
  Add test verifying app activities after RunAsync are not parented under the
  session, and that the workflow_invoke activity nests under the session."
  
  * Fix stale XML doc: WorkflowRun -> WorkflowInvoke in ObservabilityTests
  
  ---------
  
  Co-authored-by: alliscode <bentho@microsoft.com>
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Python / .NET Samples - Restructure and Improve Samples (Feature Branc… (#4092)
  
  * Python: .NET Samples - Restructure and Improve Samples (Feature Branch) (#4091)
  
  * Moved by agent (#4094)
  
  * Fix readme links
  
  * .NET Samples - Create `04-hosting` learning path step (#4098)
  
  * Agent move
  
  * Agent reorderd
  
  * Remove A2A section from README 
  
  Removed A2A section from the Getting Started README.
  
  * Agent fixed links
  
  * Fix broken sample links in durable-agents README (#4101)
  
  * Initial plan
  
  * Fix broken internal links in documentation
  
  Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
  
  * Revert template link changes; keep only durable-agents README fix
  
  Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
  
  ---------
  
  Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
  Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
  
  * .NET Samples - Create `03-workflows` learning path step (#4102)
  
  * Fix solution project path
  
  * Python: Fix broken markdown links to repo resources (outside /docs) (#4105)
  
  * Initial plan
  
  * Fix broken markdown links to repo resources
  
  Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
  
  * Update README to rename .NET Workflows Samples section
  
  ---------
  
  Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
  Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
  
  * .NET Samples - Create `02-agents` learning path step (#4107)
  
  * .NET: Fix broken relative link in GroupChatToolApproval README (#4108)
  
  * Initial plan
  
  * Fix broken link in GroupChatToolApproval README
  
  Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
  
  ---------
  
  Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
  Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
  
  * Update labeler configuration for workflow samples
  
  * .NET - Reorder Agents samples to start from Step01 instead of Step04 (#4110)
  
  * Fix solution
  
  * Resolve new sample paths
  
  * Move new AgentSkills and AgentWithMemory_Step04 samples
  
  * Fix link
  
  * Fix readme path
  
  * fix: update stale dotnet/samples/Durable path reference in AGENTS.md
  
  Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
  
  * Moved new sample
  
  * Update solution
  
  * Resolve merge (new sample)
  
  * Sync to new sample - FoundryAgents_Step21_BingCustomSearch
  
  * Updated README
  
  * .NET Samples - Configuration Naming Update (#4149)
  
  * .NET: Restore AzureFunctions index parity with ConsoleApps under DurableAgents samples (#4221)
  
  * Clean-up `05_host_your_agent`
  
  * Config setting consistency
  
  * Refine samples
  
  * AGENTS.md
  
  * Move new samples
  
  * Re-order samples
  
  * Move new project and fixup solution
  
  * Fixup model config
  
  * Fix up new UT project
  
  ---------
  
  Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
  
  * Python: Fix Bedrock embedding test stub missing meta attribute (#4287)
  
  * Fix Bedrock embedding test stub missing meta attribute
  
  * Increase test coverage so gate passes
  
  * Python: (ag-ui): fix approval payloads being re-processed on subsequent conversation turns (#4232)
  
  * Fix ag-ui tool call issue
  
  * Safe json fix
  
  * Python: Update workflow orchestration samples to use AzureOpenAIResponsesClient (#4285)
  
  * Update workflow orchestration samples to use AzureOpenAIResponsesClient
  
  * Fix broken link
  
  * Move scripts to scripts folder
  
  ---------
  
  Co-authored-by: Roger Barreto <19890735+rogerbarreto@users.noreply.github.com>
  Co-authored-by: Chris <66376200+crickman@users.noreply.github.com>
  Co-authored-by: Eduard van Valkenburg <eavanvalkenburg@users.noreply.github.com>
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  Co-authored-by: Rishabh Chawla <rishabhchawla1995@gmail.com>
  Co-authored-by: Peter Ibekwe <109177538+peibekwe@users.noreply.github.com>
  Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
  Co-authored-by: Ben Thomas <ben.thomas@microsoft.com>
  Co-authored-by: alliscode <bentho@microsoft.com>
  Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
  Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>

  westey · 2026-02-26 10:49:07 +00:00
  8b191de936
• Python: feat(python): Add embedding abstractions and OpenAI implementation (Phase 1) (#4153)

  * feat(python): Add embedding abstractions and OpenAI implementation (Phase 1)
  
  This PR contains two parts:
  
  1. **Overall migration plan** for porting vector stores and embeddings from
     Semantic Kernel to Agent Framework (docs/features/vector-stores-and-embeddings/README.md)
     covering all 10 phases from core abstractions through connectors and TextSearch.
  
  2. **Phase 1 implementation** — core embedding abstractions and OpenAI/Azure OpenAI
     embedding clients:
  
     Core types (_types.py):
     - EmbeddingGenerationOptions TypedDict (total=False)
     - Embedding[EmbeddingT] generic class with model_id, dimensions, created_at
     - GeneratedEmbeddings[EmbeddingT, EmbeddingOptionsT] list container with options, usage
     - EmbeddingInputT (default str) and EmbeddingT (default list[float]) TypeVars
  
     Protocol + base class (_clients.py):
     - SupportsGetEmbeddings protocol — Generic[EmbeddingInputT, EmbeddingT, OptionsContraT]
     - BaseEmbeddingClient ABC — Generic[EmbeddingInputT, EmbeddingT, OptionsCoT]
  
     Telemetry (observability.py):
     - EmbeddingTelemetryLayer with gen_ai.operation.name = "embeddings"
  
     OpenAI implementation (openai/_embedding_client.py):
     - RawOpenAIEmbeddingClient, OpenAIEmbeddingClient, OpenAIEmbeddingOptions
     - Uses _ensure_client() factory pattern
  
     Azure OpenAI implementation (azure/_embedding_client.py):
     - AzureOpenAIEmbeddingClient following AzureOpenAIChatClient pattern
     - Supports API key, Entra ID credentials, env var configuration
  
     Tests:
     - 47 unit tests for types, protocol, base class, OpenAI, and Azure clients
     - 6 integration tests (gated behind RUN_INTEGRATION_TESTS + credentials)
  
     Samples:
     - samples/02-agents/embeddings/openai_embeddings.py
     - samples/02-agents/embeddings/azure_openai_embeddings.py
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * fix: Add AzureOpenAIEmbeddingClient to azure __init__.pyi stub
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * ci: Add embedding env vars to Python integration tests
  
  Map OPENAI_EMBEDDING_MODEL_ID and AZURE_OPENAI_EMBEDDING_DEPLOYMENT_NAME
  from GitHub vars to the integration test environment.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * fix: Handle base64 encoding_format in OpenAI embedding client
  
  When encoding_format='base64' is used, the OpenAI API returns base64-encoded
  floats instead of a JSON array. Decode these automatically to list[float]
  so the return type stays consistent regardless of encoding format.
  
  Also adds a unit test for base64 decoding and fixes minor docstring/import issues.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * fix: Only record INPUT_TOKENS for embedding telemetry
  
  Embeddings have no output/completion tokens. Remove OUTPUT_TOKENS recording
  which was double-counting prompt_tokens via the total_tokens fallback.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * fix: Resolve mypy variance error and lint warning
  
  Use contravariant/covariant TypeVars for SupportsGetEmbeddings Protocol.
  Combine nested if into single statement in telemetry layer.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * fix: Make EmbeddingCoT invariant for mypy compatibility
  
  GeneratedEmbeddings is invariant in its type param, so the Protocol
  TypeVar cannot be covariant.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * fix: Address PR review - empty values guard, service_url for telemetry
  
  - Add early return for empty values in get_embeddings to avoid unnecessary API calls
  - Add service_url() method to RawOpenAIEmbeddingClient for proper telemetry endpoint reporting
  - Add test for empty values behavior
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Python: Fix OpenAI chat client compatibility with third-party endpoints and OTel 0.4.14 (#4161)
  
  * Fix system message content sent as list instead of string
  
  Some OpenAI-compatible endpoints (e.g. NVIDIA NIM) reject system messages
  when content is a list of content parts. This change flattens system and
  developer message content to a plain string in the Chat Completions client.
  
  Fixes https://github.com/microsoft/agent-framework/issues/1407
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Fix compatibility with opentelemetry-semantic-conventions-ai 0.4.14
  
  Version 0.4.14 removed several LLM_* attributes from SpanAttributes
  (LLM_SYSTEM, LLM_REQUEST_MODEL, LLM_RESPONSE_MODEL, LLM_REQUEST_MAX_TOKENS,
  LLM_REQUEST_TEMPERATURE, LLM_REQUEST_TOP_P, LLM_TOKEN_TYPE).
  
  Move these to the OtelAttr enum with their well-known gen_ai.* string values
  and update all references in observability.py and tests.
  
  Fixes https://github.com/microsoft/agent-framework/issues/4160
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Flatten text-only message content to string for all roles
  
  Extend the system/developer fix to all message roles. Text-only content
  lists are now post-processed into plain strings, while multimodal content
  (text + images/audio) remains as a list. This fixes compatibility with
  OpenAI-like endpoints that cannot deserialize list content (e.g. Foundry
  Local's Neutron backend).
  
  Partially fixes https://github.com/microsoft/agent-framework/issues/4084
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Fix streaming text lost when usage data in same chunk
  
  Some providers (e.g. Gemini) include both usage data and text content
  in the same streaming chunk. The early return on chunk.usage caused
  text and tool call parsing to be skipped entirely. Remove the early
  return and process usage alongside text/tool calls.
  
  Fixes https://github.com/microsoft/agent-framework/issues/3434
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Fix mypy errors in _chat_client.py
  
  Rename shadowed variable 'args' in system/developer branch to 'sys_args'
  and rename loop variable 'content' to 'msg_content' to avoid type conflict.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  ---------
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * reorder imports
  
  * fix: Use OtelAttr.REQUEST_MODEL instead of removed SpanAttributes.LLM_REQUEST_MODEL
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * docs: Add score_threshold to vector store plan
  
  Reference SK .NET PR #13501 for score threshold filtering semantics.
  Include score_threshold in SearchOptions from Phase 3.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * docs: Add reference to roji's SK .NET MEVD work for SQL connectors
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * fix: Clear env vars in construction tests to avoid CI leakage
  
  Tests for missing API key / model ID now use monkeypatch.delenv to ensure
  env vars from the integration test environment don't prevent the expected
  ValueError from being raised.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  ---------
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

  Eduard van Valkenburg · 2026-02-24 07:40:20 +00:00
  6305e3e092