2 Commits

• Python: Fix OpenAIEmbeddingClient to use AsyncOpenAI for /openai/v1 endpoints (#5137)

  * Fix OpenAIEmbeddingClient with /openai/v1 endpoint (#5068)
  
  When base_url ends with /openai/v1/ and a credential is provided,
  load_openai_service_settings was creating an AsyncAzureOpenAI client.
  The Azure SDK rewrites deployment-based endpoints (including /embeddings)
  by inserting /deployments/{model}/ into the URL, producing 404s on the
  OpenAI-compatible /openai/v1 endpoint.
  
  Use AsyncOpenAI instead of AsyncAzureOpenAI when the resolved base_url
  targets /openai/v1, converting the Azure token provider to an async
  api_key callable. The responses_mode path is unaffected because the
  Responses API (/responses) is not in the SDK's rewrite list.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Python: Fix OpenAIEmbeddingClient to use AsyncOpenAI for /openai/v1 endpoints
  
  Fixes #5068
  
  * Address review feedback: improve test coverage and remove unrelated changes
  
  - Revert unrelated formatting change in test_a2a_agent.py
  - Fix test_init_with_openai_v1_base_url_and_api_key_uses_openai_client to
    exercise the Azure settings path (via AZURE_OPENAI_BASE_URL env var)
    instead of the plain OpenAI path, covering the elif api_key branch
  - Add _ensure_async_token_provider unit tests for both sync and async
    token providers
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Address review feedback for #5068: Python: [Bug]: `OpenAIEmbeddingClient` does not work with `/openai/v1` endpoint
  
  ---------
  
  Co-authored-by: MAF Dashboard Bot <maf-dashboard-bot@users.noreply.github.com>
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>

  chetantoshniwal · 2026-04-21 19:44:25 +00:00
  57fa8ea902
• [BREAKING] Python: fix OpenAI Azure routing and provider samples (#4925)

  * Python: fix OpenAI Azure routing and provider samples
  
  Prefer OpenAI when OPENAI_API_KEY is present unless Azure is explicitly requested. Clarify constructor docs, keep deprecated Azure wrappers compatible with stricter settings validation, and refresh the provider samples and tests to use the current client patterns.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * fix bandit
  
  * Python: align OpenAI embedding Azure routing
  
  Extend the shared OpenAI-vs-Azure routing and credential behavior to the embedding client, add Azure embedding regression coverage, and refresh the embedding samples to use the generic client path.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Python: fix embedding client pyright check
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Python: thin OpenAI embedding wrapper
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Python: document embedding overload routing
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Python: fix callable OpenAI key routing
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Python: fix Azure credential routing tests
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Python: address OpenAI review feedback
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Python: narrow Azure routing markers
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Python: refine OpenAI model fallback order
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Python: narrow Azure deployment docs
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Python: remove embedding routing wording
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Python: run embedding Azure integration tests
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * changed variable name
  
  * Python: expand OpenAI package README
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * clarified readme
  
  * Python: fix Azure OpenAI integration setup
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Python: correct Azure integration env mapping
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * updated code to fix int tests
  
  * test updates
  
  * test fix
  
  * fix test setup
  
  * updates to tests and setup
  
  * remove openai assistants int tests
  
  * improvements in int tests
  
  * fix env var
  
  * fix env vars
  
  * fix azure responses test
  
  * trigger actions
  
  ---------
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

  Eduard van Valkenburg · 2026-03-27 13:33:39 +00:00
  cc0cfaaac8