3 Commits

• Simplify Python hosting core (#6492)

  Remove linking, multicast, durable delivery, and host push machinery from the v1 hosting core. Keep those scenarios in a proposed follow-up ADR and update channel packages, samples, docs, tests, and workspace metadata around the smaller host/channel contract.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

  Eduard van Valkenburg · 2026-06-12 08:34:08 +02:00
  36ce0950e4
• Python: feat(python): cross-channel hosting improvements (endpoint paths, Activity push, Telegram/Teams fixes) (#6307)

  * Update hosting channel endpoint paths
  
  Treat channel paths as concrete endpoint paths so built-in channels can be mounted at their defaults or at the app root without sample-specific subclasses. Update docs, tests, and the Foundry Telegram Invocations sample accordingly.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Add push support to ActivityProtocolChannel
  
  Implement the ChannelPush protocol so the Activity Protocol channel can
  receive cross-channel fan-out (ResponseTarget.all_linked) and echo_input
  replay as a non-originating destination:
  
  - Add push() that reconstructs a proactive Bot Framework activity (bot/user
    swap) from the stored conversation reference and POSTs it to
    /v3/conversations/{id}/activities.
  - Record a ChannelIdentity (service_url, conversation, bot, user, channel_id,
    locale) on ChannelRequest.identity so the host registers the channel under
    its isolation key for fan-out resolution.
  - Route the streaming path through deliver_response so Activity-originated
    turns broadcast like Telegram/Discord.
  - Add tests for push delivery, service_url validation, ChannelPush instance
    check, and inbound identity recording.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Don't delete Telegram webhook on shutdown by default
  
  The TelegramChannel deleted its webhook on shutdown in webhook mode. During
  a rolling redeploy the new revision registers the webhook on startup, then
  the old revision's shutdown deletes it, silently breaking inbound delivery
  until the next boot. setWebhook is overwriting/idempotent, so startup
  re-asserts the webhook every boot and no teardown is needed.
  
  Add a delete_webhook_on_shutdown flag (default False) so teardown is opt-in
  for ephemeral deployments, and leave the webhook in place otherwise.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Fix Activity channel streaming on non-Teams channels (405 on updateActivity)
  
  The Activity Protocol channel streamed replies the Teams way: POST a
  placeholder, then PUT-edit it as tokens arrive. Only Teams supports the
  updateActivity REST op; Web Chat, Direct Line and the Emulator return
  405 Method Not Allowed on the PUT, so the user saw only the placeholder.
  
  Gate the placeholder+edit flow on edit-capable channels (msteams). Other
  channels now buffer the stream and POST a single final message, mirroring
  the non-streaming path's fan-out and response-hook semantics. Also add a
  defensive 405 fallback inside the Teams edit loop so an unexpected 405
  can never strand the user on the placeholder.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * fix(hosting-activity-protocol): don't parse Teams inline attachment content as a URI
  
  Teams message activities include a text/html attachment whose inline
  `content` is raw HTML (not a URL). _parse_activity fell back to
  `attachment["content"]` and passed it to Content.from_uri, raising
  ContentError ("URI must contain a scheme") and failing the whole turn,
  so Teams users got no response.
  
  Only treat `contentUrl` as a URI, require an absolute scheme, and skip
  unparseable attachments defensively instead of failing the message.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * feat(hosting-activity-protocol): native slash-command dispatch for Teams/Activity
  
  Add a commands= parameter to ActivityProtocolChannel that intercepts a
  leading /command (after stripping the bot's own @mention) and dispatches
  to ChannelCommand handlers, mirroring the Telegram channel. Unknown
  commands fall through to the agent. The channel run_hook is applied to
  command requests so handlers observe the same resolved isolation key as
  ordinary messages, and handler errors are swallowed (200, no Bot Service
  retry of non-idempotent commands).
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * feat(hosting): silent attributed Telegram echoes + Teams markdown rendering
  
  - hosting-telegram: send cross-channel input echoes with disable_notification
    (silent) and detect echo payloads so they aren't re-broadcast.
  - hosting-activity-protocol: render outbound + push activities as textFormat
    'markdown' so Teams shows formatted replies (enables per-channel variants).
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * fix(hosting-activity-protocol): address PR #6307 review feedback
  
  Consult the host delivery pipeline even for empty streamed replies so
  ResponseTarget.none is honoured and non-originating fan-out is consulted
  instead of always emitting an originating "(no response)" message. Applies
  to both the progressive-edit (Teams) and buffered (Web Chat/Direct Line)
  streaming paths.
  
  Re-validate service_url against the allow-list in push(): the identity is
  read from a persisted store and push runs out-of-band, so the captured
  service_url must be re-checked before a bearer token is sent.
  
  Adds tests for empty-stream host consultation/suppression on both streaming
  paths and for push rejecting a disallowed service_url.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  ---------
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

  Eduard van Valkenburg · 2026-06-03 16:37:03 +02:00
  e5a6e35843
• Python: add agent-framework-hosting-activity-protocol channel (#5641)

  * feat(hosting-activity-protocol): rename Bot Framework channel to ActivityProtocolChannel
  
  The existing Bot-Framework-via-Azure-Bot-Service channel was previously
  shipped under the name ``hosting-teams`` / ``TeamsChannel``. That name
  is misleading for what the channel actually does -- it speaks the Bot
  Framework Activity Protocol against Azure Bot Service, which fans out
  across MS Teams, Slack, Webex, Telegram-via-Bot-Service, etc., and does
  not provide any Teams-specific affordances.
  
  This PR renames the package atomically and frees the ``hosting-teams``
  name for a future Teams-native channel built on
  ``microsoft-teams-apps`` (PR-5b, spec req #28).
  
  Renames (all in one commit):
  
  - Package: ``agent-framework-hosting-teams`` ->
    ``agent-framework-hosting-activity-protocol``
  - Module: ``agent_framework_hosting_teams`` ->
    ``agent_framework_hosting_activity_protocol``
  - Channel class: ``TeamsChannel`` -> ``ActivityProtocolChannel``
  - Helper: ``teams_isolation_key`` -> ``activity_protocol_isolation_key``
    (isolation key prefix ``teams:`` -> ``activity:``)
  - Channel name: ``"teams"`` -> ``"activity"``; default mount path
    ``/teams`` -> ``/activity``
  - Internal helper: ``_parse_teams_activity`` -> ``_parse_activity``
  - Worker task name + a couple of error strings updated for consistency
  
  Updates README.md and the module docstring to call out:
  
  - this is the channel-neutral Activity Protocol channel,
  - it surfaces what every Bot-Service-connected channel has in common
    (text in / text out),
  - a forthcoming ``agent-framework-hosting-teams`` package will layer
    Teams-specific affordances (adaptive cards, message extensions,
    dialogs, SSO, ...) on the same Bot Service transport.
  
  Workspace: registers ``agent-framework-hosting-activity-protocol`` in
  ``python/pyproject.toml`` and adds the matching pyright
  ``executionEnvironments`` entry.
  
  Behavior is unchanged. Pyright + mypy clean, 11 tests pass.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * review: address PR-5 round 2 feedback
  
  - security (#3198327004): add `service_url_allowed_hosts` constructor
    option (default `botframework.com` + `smba.trafficmanager.net`) and
    reject inbound activities whose `serviceUrl` host falls outside it
    with HTTP 400 — without this gate a malicious caller could redirect
    outbound replies (and the attached bearer token) to an
    attacker-controlled host
  - security (#3198324219): add `inbound_auth_validator` async callback;
    log a loud WARNING at startup when no validator AND no operator
    reverse-proxy is configured so the dev-mode bypass cannot
    accidentally ship to production. Document the contract: prototype
    intentionally does not ship JWT validation (out of scope); operators
    must plug a validator or terminate auth in front of the channel
  - retry semantics (#3198328746): distinguish transient outbound
    failures (httpx network errors, non-2xx from Bot Service) — return
    502 so Bot Service retries — from deterministic agent failures —
    return 200 so Bot Service does not retry the same broken activity
    in a loop
  - bug (#3198330424): fix the placeholder-failure deadlock. When
    `send_initial_placeholder` fails, `activity_id` stays `None`, the
    edit-worker loop exit condition (`accumulated == last_sent`) is
    unreachable while no PUT is possible, and the worker would deadlock
    on `wake.wait()` forever after `worker_done` is set. Now: skip the
    worker entirely on placeholder failure and POST a single final
    activity at the end with whatever accumulated
  - tests (#3198334465, #3187178091, #3198336045): add coverage for
    - `_is_service_url_allowed` allow/deny matrix + webhook 400 on
      disallowed serviceUrl
    - `inbound_auth_validator` allow/deny/raises paths
    - outbound `Authorization: Bearer <token>` header presence in
      production mode and absence in dev mode
    - the streaming path (`_stream_to_conversation`): placeholder +
      final edit, placeholder-failure fallback (with timeout guard
      against deadlock regression), and empty-stream `(no response)`
      placeholder replacement
    - retry-signal differentiation: outbound `httpx.ConnectError` →
      502; deterministic `ValueError` from the agent → 200
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * test(hosting): drop redundant @pytest.mark.asyncio decorators
  
  asyncio_mode = "auto" is configured in pyproject.toml across the
  hosting packages, so individual @pytest.mark.asyncio decorators are
  unnecessary.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * feat(hosting-activity-protocol): add response hooks
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * docs(hosting-activity-protocol): mark constructor keyword args
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  ---------
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

  Eduard van Valkenburg · 2026-05-28 14:37:18 +02:00
  cdea9fa956