1 Commits

• .NET: Fix declarative workflow regressions for hosted agents (#5905)

  * Fix declarative workflow regressions for hosted agents
  
  Three regressions surfaced when running a declarative workflow as a
  Foundry hosted agent. Together they caused every condition group to fall
  through to elseActions and the raw agent JSON to leak to the caller.
  
  1. AgentProviderExtensions.InvokeAgentAsync forced autoSend to true
     whenever the agent ran on the workflow conversation, which overrode
     the explicit autoSend: false declared in workflow.yaml and streamed
     the raw structured-output JSON straight to the user. Honor the
     caller-supplied autoSend instead.
  
  2. IWorkflowContextExtensions.ReadState / QueueStateUpdateAsync /
     QueueStateResetAsync took the variable name and namespace alias
     directly from PropertyPath.VariableName / NamespaceAlias. Against
     Microsoft.Agents.ObjectModel 2026.2.4.1 those properties return null
     for a dotted reference such as `Local.Triage` even when
     SegmentCount == 2 and IsValid == true, so every assignment threw
     ArgumentNullException via Throw.IfNull. Fall back to Segments() to
     reconstruct the name and alias when the parser returns null.
  
  3. The same ObjectModel version no longer recognizes the user-facing
     `Local` scope alias: VariableScopeNames.IsValidName(`Local`)
     returns false and GetNamespaceFromName(`Local`) returns Unknown, so
     the declarative interpreter's IsManagedScope check fails and the
     State.Set call is silently skipped. Translate the `Local` alias to
     its canonical `Topic` form before forwarding to
     QueueStateUpdateAsync; WorkflowFormulaState.Bind continues to expose
     it as `Local` to PowerFx.
  
  Verified end-to-end against a deployed Foundry hosted agent: the
  declarative triage workflow now routes Technical / Billing / General
  inputs correctly and only the autoSend-eligible messages reach the
  caller.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Hosted-agent HITL: persist session across previous_response_id chains; run approved local AIFunctions
  
  Two regressions hit declarative workflows that use require_approval=true when
  the client chains turns via previous_response_id (no conversation_id):
  
  1. AgentFrameworkResponseHandler keyed the AgentSession store solely on
     conversation_id, so when only previous_response_id was present the
     StateBag (which holds ToolApprovalIdMap) was discarded after each turn.
     The next turn then threw 'No approval mapping recorded for wire id ...'
     in InputConverter.ConvertMcpApprovalResponse.
  
     Fix: fall back to previous_response_id on load and to context.ResponseId
     on save so the response-id chain becomes a valid session key. Conversation
     id remains preferred when present.
  
  2. InvokeFunctionToolExecutor.CaptureResponseAsync only acted on
     FunctionResultContent. In the hosted Foundry path the approval response
     arrives as a ToolApprovalResponseContent with no FunctionResultContent,
     so the local AIFunction never ran and downstream PropertyPath/SendActivity
     consumers (e.g. {Local.RefundResult}) saw empty values.
  
     Fix: when no FunctionResultContent matches but an approved
     ToolApprovalResponseContent does, look up the registered AIFunction by
     name on agentProvider.Functions and invoke it with the evaluated
     arguments, surfacing the result through the existing assignment path.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Apply PropertyPath workaround to initialization path; share + tidy helpers
  
  Address PR #5905 review feedback:
  
  * Move the PropertyPath VariableName/NamespaceAlias fallback and 'Local'
    -> 'Topic' scope remap into a shared internal PropertyPathExtensions
    helper. Materializes Segments() once, names the magic 'Local' alias
    as a const, and carries a TODO referencing the tracking issue.
  
  * Apply the same helper in WorkflowDiagnostics.InitializeDefaults so a
    declared default for a dotted variable like 'Local.Triage' is no
    longer silently skipped at workflow startup (closes the gap flagged
    by the reviewer: runtime ReadState/QueueStateUpdateAsync worked but
    state.Initialize did not).
  
  * Restore the previous strict failure mode on namespace alias by
    wrapping GetNamespaceAlias() in Throw.IfNull at call sites so a
    malformed single-segment path keeps failing fast rather than
    silently passing null to State.Get/Set.
  
  All 821 unit tests pass.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Add tests for AgentProviderExtensions.InvokeAgentAsync autoSend behavior
  
  Covers the autoSend regression fix: when the agent runs on the workflow conversation with autoSend=false, no AgentResponseUpdateEvent or AgentResponseEvent is added to the context. Also covers autoSend=true (events emitted) and autoSend=false on a non-workflow conversation.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Surface SendActivity output via AgentResponseUpdateEvent
  
  SendActivityExecutor previously only emitted the activity text via YieldOutputAsync, which the runtime converts to an AgentResponseEvent. WorkflowSession gates AgentResponseEvent behind includeWorkflowOutputsInResponse, so when a host opts out of summary outputs (the default for AsAIAgent) the SendActivity reply is silently dropped.
  
  Mirror the pattern used by AgentProviderExtensions for autoSend agent invocations: also emit an AgentResponseUpdateEvent, which WorkflowSession yields unconditionally. This makes SendActivity reliably reach chat-protocol clients without requiring includeWorkflowOutputsInResponse = true (which would also duplicate autoSend agent output).
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Revert previous_response_id session-key fallback
  
  The fallback let a session be keyed by an unbroken previous_response_id chain,
  but conversation_id is the right way to thread state across turns: it survives
  shared/branched chains (e.g. when another agent generates a response in between)
  and is the documented model for stateful clients. Restore conversation_id as the
  sole session key and rely on the client to thread it. The InvokeFunctionTool
  approval/local-function half of 1baf4af4d remains.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Set Foundry ProductContext per-executor instead of via PropertyPath workaround
  
  ObjectModel 2026.2.4.1 resolves PropertyPath.VariableName / NamespaceAlias and VariableScopeNames.IsValidName against AsyncLocal<ProductContext> at access time. In hosted-agent scenarios each HTTP request runs on a fresh async context where that AsyncLocal is default, so dotted refs like Local.Triage returned null and the Local scope alias was rejected.
  
  Replace the PropertyPathExtensions helper (which papered over both symptoms) with a single WorkflowDiagnostics.SetFoundryProduct() call at the entry of DeclarativeActionExecutor.HandleAsync. The set writes to the request's logical async context before any code reads PropertyPath, letting the existing parser and scope resolver work as designed.
  
  Validated: 824/824 declarative unit tests pass; technical/billing/general routes all dispatch correctly against a deployed Foundry hosted agent.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Address review feedback on InvokeFunctionToolExecutor
  
  - Surface registered-function lookup failures and invocation exceptions via FunctionResultContent.Exception instead of returning the error text as a successful Result, so downstream {Local.X} assignments can distinguish failures from successes.
  
  - Use AIJsonUtilities.DefaultOptions to JSON-serialize non-string function results (matching FunctionInvokingChatClient / ToolBridge), so complex types stay consumable by PropertyPath consumers instead of degrading to Object.ToString().
  
  - Drop the explicit System. prefix on StringComparison / Exception now that the file imports System.
  
  - Add AutoSendTrueOnExternalConversationEmitsResponseEventsAndCopiesMessagesAsync to cover the (autoSend: true, external conversation) quadrant, asserting that response events are emitted and that messages are mirrored to the workflow conversation.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Honor AutoSendIsDefaultValue when computing autoSend
  
  AzureAgentOutput.AutoSend and InvokeToolOutput.AutoSend in
  Microsoft.Agents.ObjectModel 2026.2.4.1 are never null — they
  return a literal-false default when the YAML omits the field.
  The previous null check in Get/AutoSendValue therefore always
  fell through to evaluating the literal false, so every action
  whose YAML had any output block but no explicit autoSend was
  treated as autoSend = false. This was previously masked by
  `autoSend |= isWorkflowConversation` in AgentProviderExtensions
  (removed earlier in this PR to honor explicit autoSend: false),
  which silently re-enabled autoSend on the workflow conversation.
  
  Use AutoSendIsDefaultValue to distinguish an explicit autoSend
  value from the implicit default and treat the implicit default
  as true, restoring the historical behavior for ValidateCaseAsync
  InvokeAgent.yaml (3 InvokeAzureAgent actions, last one captures
  to Local.RatingResponse via output.messages with no autoSend
  specified) while keeping the hosted-agent fix that honors an
  explicit autoSend: false.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  ---------
  
  Co-authored-by: Ben Thomas <25218250+alliscode@users.noreply.github.com>
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

  Ben Thomas · 2026-05-22 01:06:38 +00:00
  b559545fa4