2 Commits

• .NET: Add dedicated Foundry.Hosting UnitTest project (#5592)

  * Foundry.Hosting.UnitTests: extract project from Foundry.UnitTests
  
  Move all Hosting/* tests, three toolbox TestData JSONs, and the FakeAuthenticationTokenProvider/HttpHandlerAssert/TestDataUtil helpers (trimmed to toolbox getters) into a new Microsoft.Agents.AI.Foundry.Hosting.UnitTests project. Add it to the slnx and grant the new assembly InternalsVisibleTo from Microsoft.Agents.AI.Foundry and Microsoft.Agents.AI.Foundry.Hosting.
  
  * Foundry.Hosting.UnitTests: align namespaces to assembly name
  
  Rename namespaces from Microsoft.Agents.AI.Foundry.UnitTests(.Hosting) to Microsoft.Agents.AI.Foundry.Hosting.UnitTests across all moved tests, the duplicated helpers, and the trimmed TestDataUtil. Also fixes the prior namespace inconsistency in FoundryToolboxTests.
  
  * Foundry.Hosting.UnitTests: split WorkflowIntegrationTests by SUT
  
  Replace the WorkflowIntegrationTests file (an IT-named file inside a UT project) with two SUT-focused files plus a shared test-doubles file:
  
  - AgentFrameworkResponseHandlerWorkflowTests.cs - the 5 handler-driven tests that exercise AgentFrameworkResponseHandler with a real workflow agent.
  - OutputConverterWorkflowTests.cs - the 5 OutputConverter tests driven by hand-crafted update sequences mirroring real workflow patterns.
  - WorkflowTestAgents.cs - StreamingTextAgent and ThrowingStreamingAgent extracted as internal types used by both files.
  
  * Foundry.UnitTests: trim Hosting-related conditionals and dead testdata
  
  Now that Hosting tests live in their own project:
  - drop the Compile Remove guard for the Hosting subfolder,
  - drop the .NETCoreApp-only PackageReferences (Azure.AI.AgentServer.Responses, Microsoft.AspNetCore.TestHost, OpenTelemetry, OpenTelemetry.Exporter.InMemory),
  - drop the conditional ProjectReference to Microsoft.Agents.AI.Foundry.Hosting,
  - delete the three Toolbox JSON files and the matching Toolbox getters in TestDataUtil.
  
  * Foundry.Hosting.UnitTests: drop redundant 'using Microsoft.Agents.AI.Foundry.Hosting'
  
  The new project namespace is Microsoft.Agents.AI.Foundry.Hosting.UnitTests, which already brings the parent Microsoft.Agents.AI.Foundry.Hosting namespace into scope. The explicit using statement is therefore redundant (IDE0005). Caught by 'dotnet format --verify-no-changes' running on Linux against the .NET 10 SDK.
  
  * Foundry.Hosting: drop InternalsVisibleTo to Foundry.UnitTests
  
  The non-hosting Foundry.UnitTests project no longer holds any Hosting tests after the split, so it doesn't need access to internal types in Microsoft.Agents.AI.Foundry.Hosting. Only Microsoft.Agents.AI.Foundry.Hosting.UnitTests needs it.
  
  * Foundry.Hosting: rename DelegatingResponsesClient to UserAgentResponsesClient
  
  Address westey-m's review feedback on PR #5453: `Delegating*` is conventionally reserved for inheritable base classes (mirroring `DelegatingHandler`) where consumers override one or two members. This polyfill is sealed and only injects the User-Agent supplement, so the new name reflects its actual purpose.
  
  Renamed via `git mv` to preserve history:
  * `src/Microsoft.Agents.AI.Foundry.Hosting/DelegatingResponsesClient.cs` to `UserAgentResponsesClient.cs`
  * `tests/Microsoft.Agents.AI.Foundry.Hosting.UnitTests/DelegatingResponsesClientTests.cs` to `UserAgentResponsesClientTests.cs`
  
  Class, constructor, and all references updated across:
  * `src/.../UserAgentResponsesClient.cs` (class + constructor + internal log message)
  * `src/.../ServiceCollectionExtensions.cs` (cref + type check + instantiation)
  * `src/.../HostedAgentUserAgentPolicy.cs` (cref)
  * `tests/Foundry.UnitTests/RequestOptionsExtensionsTests.cs` (comment)
  * `tests/Foundry.Hosting.UnitTests/UserAgentResponsesClientTests.cs` (class + cref + instantiations)

  Roger Barreto · 2026-04-30 21:09:25 +00:00
  fb97e93a01
• .NET: dotnet: Add hosted-agent User-Agent supplement to outgoing requests (#5453)

  * dotnet: Add hosted-agent User-Agent supplement to outgoing requests
  
  When an agent runs inside a Foundry Hosted Agent, the outgoing
  User-Agent header now includes 'agent-framework-hosted/{version}'
  alongside the existing 'MEAI/{version}' segment.
  
  - Add HostedAgentContext with AsyncLocal<string?> property
  - MeaiUserAgentPolicy reads the supplement per-call
  - AgentFrameworkResponseHandler sets/restores the context
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * chore: update hosted UA format to foundry-hosting/agent-framework-dotnet/{version}
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Trying to get UA flowing, no luck yet.
  
  * .NET: Polyfill MEAI OpenAIResponsesChatClient to add hosted-agent User-Agent supplement
  
  When AgentFrameworkResponseHandler resolves an agent (i.e. we are running in a
  hosted context), TryApplyUserAgent walks the agent's IChatClient decorator chain
  to find MEAI's internal OpenAIResponsesChatClient and reflectively swaps its
  inner _responseClient field with a DelegatingResponsesClient wrapper. The
  wrapper overrides the public-virtual protocol methods to add a per-call
  HostedAgentUserAgentPolicy to the RequestOptions and delegate to the inner
  ResponsesClient. The OpenAI SDK's internal streaming overloads bottom out in
  calls to the public-virtual non-streaming overloads via virtual dispatch on
  this, so streaming is covered without overriding any non-virtual member.
  
  The wrapper accepts any ResponsesClient-derived inner — both the Foundry
  ProjectResponsesClient and the native OpenAI ResponsesClient — and preserves
  the inner client's full pipeline (Transport, RetryPolicy, NetworkTimeout,
  OrganizationId / ProjectId / UserAgentApplicationId, custom policies).
  
  - Add DelegatingResponsesClient + HostedAgentUserAgentPolicy in Microsoft.Agents.AI.Foundry.Hosting.
  - Add TryApplyUserAgent next to ApplyOpenTelemetry in FoundryHostingExtensions; wire it into AgentFrameworkResponseHandler.GetAgent for both keyed and default-agent paths.
  - Drop earlier-iteration dead code: AddHostedAgentTelemetry extension, HostedUserAgentPolicy class, HostedAgentContext.cs, and the never-called ToRequestOptions helper.
  - Revert RequestOptionsExtensions.MeaiUserAgentPolicy to MEAI-only (the supplement is now injected by the polyfill).
  - Revert unrelated whitespace change in Agent_Step25_ToolboxServerSideTools sample.
  - Tests cover streaming AND non-streaming, retry policy preservation, OrganizationId/ProjectId/UserAgentApplicationId pass-through, idempotency, native OpenAI ResponsesClient, and reflection guards for MEAI/OpenAI shape drift.
  
  * .NET: Address review feedback on hosted-agent User-Agent polyfill
  
  - TryApplyUserAgent: replace silent null-return with ArgumentNullException to match the codebase's convention.
  - Add idempotency test (TryApplyUserAgent_CalledTwiceOnSameAgent_DoesNotDoubleWrap) — runs the polyfill twice on the same agent and asserts the wire UA contains exactly one foundry-hosting segment, proving the 'current is DelegatingResponsesClient' guard prevents nested wrapping.
  - Add retry-double-append test (Polyfill_RetryWithinCall_DoesNotDuplicateSupplementInUserAgent) — exercises the HostedAgentUserAgentPolicy Contains-guard via a custom retry policy that re-runs the inner pipeline on the same message.
  - Replace TryApplyUserAgent_NullAgent_ReturnsNullWithoutThrowing with TryApplyUserAgent_NullAgent_ThrowsArgumentNullException to match the new contract.
  
  * .NET: Drop null check from TryApplyUserAgent and its now-redundant test
  
  The two call sites in AgentFrameworkResponseHandler.GetAgent already null-check the agent before invoking TryApplyUserAgent, so the defensive ArgumentNullException is unreachable. Remove it and the corresponding test.
  
  * .NET: Remove unused Microsoft.Shared.Diagnostics import in ServiceCollectionExtensions
  
  The Throw.IfNull helper from this namespace was used by the now-removed null check in TryApplyUserAgent. Drop the unused import to satisfy IDE0005 in CI's full-project dotnet format run.
  
  ---------
  
  Co-authored-by: alliscode <bentho@microsoft.com>
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  Co-authored-by: Roger Barreto <19890735+rogerbarreto@users.noreply.github.com>

  Ben Thomas · 2026-04-30 16:37:54 +00:00
  6cd81286a9