From f36cc40080688cbff884fbe902ebebfe95b08a0c Mon Sep 17 00:00:00 2001 From: Eduard van Valkenburg Date: Mon, 28 Jul 2025 11:37:26 +0200 Subject: [PATCH] different secret for python tests (#248) --- .github/workflows/python-merge-tests.yml | 2 +- python/packages/azure/tests/test_azure_chat_client.py | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/python-merge-tests.yml b/.github/workflows/python-merge-tests.yml index f1deed4c9b..156e832de0 100644 --- a/.github/workflows/python-merge-tests.yml +++ b/.github/workflows/python-merge-tests.yml @@ -81,7 +81,7 @@ jobs: env: UV_PYTHON: ${{ matrix.python-version }} AZURE_OPENAI_CHAT_DEPLOYMENT_NAME: ${{ vars.AZUREAI__DEPLOYMENTNAME }} - AZURE_OPENAI_ENDPOINT: ${{ secrets.AZUREAI__ENDPOINT }} + AZURE_OPENAI_ENDPOINT: ${{ secrets.AZURE_OPENAI_ENDPOINT }} PACKAGE_NAME: "azure" defaults: run: diff --git a/python/packages/azure/tests/test_azure_chat_client.py b/python/packages/azure/tests/test_azure_chat_client.py index a2fe54604f..face9cbb13 100644 --- a/python/packages/azure/tests/test_azure_chat_client.py +++ b/python/packages/azure/tests/test_azure_chat_client.py @@ -647,9 +647,7 @@ def get_story_text() -> str: async def test_azure_openai_chat_client_response() -> None: """Test Azure OpenAI chat completion responses.""" azure_chat_client = AzureChatClient() - assert isinstance(azure_chat_client, ChatClient) - print(f"Using Azure OpenAI endpoint: {azure_chat_client.client._azure_endpoint}") # noqa messages: list[ChatMessage] = [] messages.append( @@ -675,7 +673,6 @@ async def test_azure_openai_chat_client_response() -> None: async def test_azure_openai_chat_client_response_tools() -> None: """Test AzureOpenAI chat completion responses.""" azure_chat_client = AzureChatClient() - assert isinstance(azure_chat_client, ChatClient) messages: list[ChatMessage] = [] @@ -697,7 +694,6 @@ async def test_azure_openai_chat_client_response_tools() -> None: async def test_azure_openai_chat_client_streaming() -> None: """Test Azure OpenAI chat completion responses.""" azure_chat_client = AzureChatClient() - assert isinstance(azure_chat_client, ChatClient) messages: list[ChatMessage] = [] @@ -730,7 +726,6 @@ async def test_azure_openai_chat_client_streaming() -> None: async def test_azure_openai_chat_client_streaming_tools() -> None: """Test AzureOpenAI chat completion responses.""" azure_chat_client = AzureChatClient() - assert isinstance(azure_chat_client, ChatClient) messages: list[ChatMessage] = []