From e6f194bce5e4dd5611cc5d5c37623e6539501ca4 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 13 May 2026 19:21:42 +0000 Subject: [PATCH] Relax builder null assertion parameter checks Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/af831ee2-0a99-4427-9ffd-a3b5022c1b3b Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com> --- .../WorkflowBuilderSmokeTests.cs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/WorkflowBuilderSmokeTests.cs b/dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/WorkflowBuilderSmokeTests.cs index 74e911eefe..08f14ea541 100644 --- a/dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/WorkflowBuilderSmokeTests.cs +++ b/dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/WorkflowBuilderSmokeTests.cs @@ -364,7 +364,7 @@ public partial class WorkflowBuilderSmokeTests NoOpExecutor target = new("target"); // Act/Assert - Assert.Throws("builder", () => ((WorkflowBuilder)null!).ForwardMessage(source, target)); + Assert.Throws(() => ((WorkflowBuilder)null!).ForwardMessage(source, target)); Assert.Throws("source", () => builder.ForwardMessage(null!, target)); Assert.Throws("target", () => builder.ForwardMessage(source, (ExecutorBinding)null!)); Assert.Throws("targets", () => builder.ForwardMessage(source, (IEnumerable)null!)); @@ -381,7 +381,7 @@ public partial class WorkflowBuilderSmokeTests NoOpExecutor target = new("target"); // Act/Assert - Assert.Throws("builder", () => ((WorkflowBuilder)null!).ForwardExcept(source, target)); + Assert.Throws(() => ((WorkflowBuilder)null!).ForwardExcept(source, target)); Assert.Throws("source", () => builder.ForwardExcept(null!, target)); Assert.Throws("target", () => builder.ForwardExcept(source, (ExecutorBinding)null!)); Assert.Throws("targets", () => builder.ForwardExcept(source, (IEnumerable)null!)); @@ -399,7 +399,7 @@ public partial class WorkflowBuilderSmokeTests NoOpExecutor otherTarget = new("other-target"); // Act/Assert - Assert.Throws("builder", () => ((WorkflowBuilder)null!).AddChain(source, [target])); + Assert.Throws(() => ((WorkflowBuilder)null!).AddChain(source, [target])); Assert.Throws("source", () => builder.AddChain(null!, [target])); Assert.Throws("executors", () => builder.AddChain(source, null!)); Assert.Throws("executors", () => builder.AddChain(source, [target, null!])); @@ -415,7 +415,7 @@ public partial class WorkflowBuilderSmokeTests NoOpExecutor source = new("start"); // Act/Assert - Assert.Throws("builder", () => ((WorkflowBuilder)null!).AddExternalCall(source, "port")); + Assert.Throws(() => ((WorkflowBuilder)null!).AddExternalCall(source, "port")); Assert.Throws("source", () => builder.AddExternalCall(null!, "port")); Assert.Throws("portId", () => builder.AddExternalCall(source, null!)); } @@ -428,7 +428,7 @@ public partial class WorkflowBuilderSmokeTests NoOpExecutor source = new("start"); // Act/Assert - Assert.Throws("builder", () => ((WorkflowBuilder)null!).AddSwitch(source, _ => { })); + Assert.Throws(() => ((WorkflowBuilder)null!).AddSwitch(source, _ => { })); Assert.Throws("source", () => builder.AddSwitch(null!, _ => { })); Assert.Throws("configureSwitch", () => builder.AddSwitch(source, null!)); Assert.Throws("targets", () => builder.AddSwitch(source, _ => { }));