From c5dc3b98fd866b3cb6671cdbc8268c0330d56635 Mon Sep 17 00:00:00 2001 From: Evan Mattson Date: Thu, 26 Feb 2026 20:20:02 +0900 Subject: [PATCH] Add explicit validation for empty model_id in AzureOpenAIResponsesClient Reject empty or whitespace-only model_id with ValueError instead of silently passing an empty deployment name downstream. This ensures the test_init_model_id_kwarg_empty_string test correctly validates behavior defined in production code rather than relying on downstream validation. Addresses PR review feedback for #4299. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- python/packages/core/agent_framework/azure/_responses_client.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/python/packages/core/agent_framework/azure/_responses_client.py b/python/packages/core/agent_framework/azure/_responses_client.py index a96d596176..a412adcaf0 100644 --- a/python/packages/core/agent_framework/azure/_responses_client.py +++ b/python/packages/core/agent_framework/azure/_responses_client.py @@ -181,6 +181,8 @@ class AzureOpenAIResponsesClient( # type: ignore[misc] response = await client.get_response("Hello", options={"my_custom_option": "value"}) """ model_id = kwargs.pop("model_id", None) + if model_id is not None and not str(model_id).strip(): + raise ValueError("model_id must not be empty") if model_id is not None and deployment_name is None: deployment_name = str(model_id)