agent/agent-framework
1
0
Fork 0
mirror of https://github.com/microsoft/agent-framework.git synced 2026-06-16 21:04:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: Remove strict thread id validation for tool results (#1769)

Browse Source 
* fix: remove strict thread id validation for tool results

* test: remove corresponding test for strict thread_id validation
This commit is contained in:
Kurt
2025-10-30 22:32:46 +08:00
committed by GitHub
Unverified
parent fb7086b2e0
commit abfdf75cfb
2 changed files with 0 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/packages/azure-ai/agent_framework_azure_ai/_chat_client.py
-3
View File
@@ -337,9 +337,6 @@ class AzureAIAgentClient(BaseChatClient):
else run_options.get("conversation_id", self.thread_id)
)
if thread_id is None and required_action_results is not None:
raise ValueError("No thread ID was provided, but chat messages includes tool results.")
# Determine which agent to use and create if needed
agent_id = await self._get_agent_id_or_create(run_options)
python/packages/azure-ai/tests/test_azure_ai_agent_client.py
-23
View File
@@ -294,29 +294,6 @@ async def test_azure_ai_chat_client_get_agent_id_or_create_create_new(
assert chat_client._should_delete_agent # type: ignore
async def test_azure_ai_chat_client_tool_results_without_thread_error_via_public_api(
mock_ai_project_client: MagicMock,
) -> None:
"""Test that tool results without thread ID raise error through public API."""
chat_client = create_test_azure_ai_chat_client(mock_ai_project_client, agent_id="test-agent")
# Mock get_agent
mock_ai_project_client.agents.get_agent = AsyncMock(return_value=None)
# Create messages with tool results but no thread/conversation ID
messages = [
ChatMessage(role=Role.USER, text="Hello"),
ChatMessage(
role=Role.TOOL, contents=[FunctionResultContent(call_id='["run_123", "call_456"]', result="Result")]
),
]
# This should raise ValueError when called through public API
with pytest.raises(ValueError, match="No thread ID was provided, but chat messages includes tool results"):
async for _ in chat_client.get_streaming_response(messages):
pass
async def test_azure_ai_chat_client_thread_management_through_public_api(mock_ai_project_client: MagicMock) -> None:
"""Test thread creation and management through public API."""
chat_client = create_test_azure_ai_chat_client(mock_ai_project_client, agent_id="test-agent")