agent/agent-framework
2
0
Fork 0
mirror of https://github.com/microsoft/agent-framework.git synced 2026-06-16 21:04:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

Python: [BREAKING] Standardize TypeVar naming convention (TName → NameT) (#3770)

Browse Source 
* standardized typevar to use suffix T

* addressed copilot comments
This commit is contained in:
Giles Odigwe
2026-02-10 19:34:10 +00:00
committed by GitHub
parent 7dccf3a07b
commit a149aaa926
40 changed files with 443 additions and 437 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/packages/bedrock/agent_framework_bedrock/_chat_client.py
+8 -8
View File
@@ -62,7 +62,7 @@ __all__ = [
"BedrockSettings",
]
TResponseModel = TypeVar("TResponseModel", bound=BaseModel | None, default=None)
ResponseModelT = TypeVar("ResponseModelT", bound=BaseModel | None, default=None)
# region Bedrock Chat Options TypedDict
@@ -91,7 +91,7 @@ class BedrockGuardrailConfig(TypedDict, total=False):
"""How to process guardrails during streaming (sync blocks, async does not)."""
class BedrockChatOptions(ChatOptions[TResponseModel], Generic[TResponseModel], total=False):
class BedrockChatOptions(ChatOptions[ResponseModelT], Generic[ResponseModelT], total=False):
"""Amazon Bedrock Converse API-specific chat options dict.
Extends base ChatOptions with Bedrock-specific parameters.
@@ -183,7 +183,7 @@ BEDROCK_OPTION_TRANSLATIONS: dict[str, str] = {
}
"""Maps ChatOptions keys to Bedrock Converse API parameter names."""
TBedrockChatOptions = TypeVar("TBedrockChatOptions", bound=TypedDict, default="BedrockChatOptions", covariant=True) # type: ignore[valid-type]
BedrockChatOptionsT = TypeVar("BedrockChatOptionsT", bound=TypedDict, default="BedrockChatOptions", covariant=True) # type: ignore[valid-type]
# endregion
@@ -219,11 +219,11 @@ class BedrockSettings(AFBaseSettings):
class BedrockChatClient(
ChatMiddlewareLayer[TBedrockChatOptions],
FunctionInvocationLayer[TBedrockChatOptions],
ChatTelemetryLayer[TBedrockChatOptions],
BaseChatClient[TBedrockChatOptions],
Generic[TBedrockChatOptions],
ChatMiddlewareLayer[BedrockChatOptionsT],
FunctionInvocationLayer[BedrockChatOptionsT],
ChatTelemetryLayer[BedrockChatOptionsT],
BaseChatClient[BedrockChatOptionsT],
Generic[BedrockChatOptionsT],
):
"""Async chat client for Amazon Bedrock's Converse API with middleware, telemetry, and function invocation."""