Python: Improved telemetry setup (#421)

* test with stack and simplified names

* quick demo of agent decorator

* moved builder to protocol to enhance functionality

* undid chatclientAgent -> agent rename

* one more

* reverted AIAgent rename

* final reverts

* fixed foundry import

* revert changes

* streamlined otel and fcc decorators

* cleanup of telemetry

* further refinement

* lots of updates

* fixed typing

* fix for mypy

* added input and output atttributes

* fix import

* initial work on baking in otel

* major update to telemetry

* final fixes after rename

* fix

* fix test

* updated tests

* fix for tests

* fixes for tests

* updated based on comments

* removed agent decorator

* fix for Python: ServiceResponseException when using multiple tools
Fixes #649

* addressed comments

* fix tests

* fix tests

* fix tools tests

* fix for conversation_id in assistants client

* fix responses test

* fix tests and mypy

* updated test

* foundry fix

---------

Co-authored-by: Chris <66376200+crickman@users.noreply.github.com>

python/packages/main/tests/openai/conftest.py

@@ -3,6 +3,8 @@ from typing import Any
 
 from pytest import fixture
 
+from agent_framework.telemetry import OtelSettings, setup_telemetry
+
 
 # region Connector Settings fixtures
 @fixture
@@ -49,3 +51,26 @@ def openai_unit_test_env(monkeypatch, exclude_list, override_env_param_dict):  #
         monkeypatch.setenv(key, value)  # type: ignore
 
     return env_vars
+
+
+@fixture
+def enable_otel(request: Any) -> bool:
+    """Fixture that returns a boolean indicating if Otel is enabled."""
+    return request.param if hasattr(request, "param") else True
+
+
+@fixture
+def enable_sensitive_data(request: Any) -> bool:
+    """Fixture that returns a boolean indicating if sensitive data is enabled."""
+    return request.param if hasattr(request, "param") else False
+
+
+@fixture
+def otel_settings(enable_otel: bool, enable_sensitive_data: bool) -> OtelSettings:
+    """Fixture to set environment variables for OtelSettings."""
+
+    from agent_framework.telemetry import OTEL_SETTINGS
+
+    setup_telemetry(enable_otel=enable_otel, enable_sensitive_data=enable_sensitive_data)
+
+    return OTEL_SETTINGS

python/packages/main/tests/openai/test_openai_responses_client.py

@@ -373,7 +373,7 @@ def test_chat_message_parsing_with_function_calls() -> None:
         asyncio.run(client.get_response(messages=messages))
 
 
-def test_response_format_parse_path() -> None:
+async def test_response_format_parse_path() -> None:
     """Test get_response response_format parsing path."""
     client = OpenAIResponsesClient(ai_model_id="test-model", api_key="test-key")
 
@@ -386,19 +386,18 @@ def test_response_format_parse_path() -> None:
     mock_parsed_response.metadata = {}
     mock_parsed_response.output_parsed = None
     mock_parsed_response.usage = None
+    mock_parsed_response.finish_reason = None
 
     with patch.object(client.client.responses, "parse", return_value=mock_parsed_response):
-        response = asyncio.run(
-            client.get_response(
-                messages=[ChatMessage(role="user", text="Test message")], response_format=OutputStruct, store=True
-            )
+        response = await client.get_response(
+            messages=[ChatMessage(role="user", text="Test message")], response_format=OutputStruct, store=True
         )
 
         assert response.conversation_id == "parsed_response_123"
         assert response.ai_model_id == "test-model"
 
 
-def test_bad_request_error_non_content_filter() -> None:
+async def test_bad_request_error_non_content_filter() -> None:
     """Test get_response BadRequestError without content_filter."""
     client = OpenAIResponsesClient(ai_model_id="test-model", api_key="test-key")
 
@@ -412,10 +411,8 @@ def test_bad_request_error_non_content_filter() -> None:
 
     with patch.object(client.client.responses, "parse", side_effect=mock_error):
         with pytest.raises(ServiceResponseException) as exc_info:
-            asyncio.run(
-                client.get_response(
-                    messages=[ChatMessage(role="user", text="Test message")], response_format=OutputStruct
-                )
+            await client.get_response(
+                messages=[ChatMessage(role="user", text="Test message")], response_format=OutputStruct
             )
 
         assert "failed to complete the prompt" in str(exc_info.value)
@@ -440,11 +437,13 @@ async def test_streaming_content_filter_exception_handling() -> None:
                 break
 
 
-def test_get_streaming_response_with_all_parameters() -> None:
+@skip_if_openai_integration_tests_disabled
+async def test_get_streaming_response_with_all_parameters() -> None:
     """Test get_streaming_response with all possible parameters."""
     client = OpenAIResponsesClient(ai_model_id="test-model", api_key="test-key")
 
-    async def run_streaming_test():
+    # Should fail due to invalid API key
+    with pytest.raises(ServiceResponseException):
         response = client.get_streaming_response(
             messages=[ChatMessage(role="user", text="Test streaming")],
             include=["file_search_call.results"],
@@ -471,10 +470,6 @@ def test_get_streaming_response_with_all_parameters() -> None:
         async for _ in response:
             break
 
-    # Should fail due to invalid API key
-    with pytest.raises(ServiceResponseException):
-        asyncio.run(run_streaming_test())
-
 
 def test_response_content_creation_with_annotations() -> None:
     """Test _create_response_content with different annotation types."""
@@ -731,7 +726,9 @@ def test_create_streaming_response_content_with_mcp_approval_request() -> None:
     assert fa.function_call.name == "do_stream_action"
 
 
-def test_end_to_end_mcp_approval_flow() -> None:
+@pytest.mark.parametrize("enable_otel", [False], indirect=True)
+@pytest.mark.parametrize("enable_sensitive_data", [False], indirect=True)
+def test_end_to_end_mcp_approval_flow(otel_settings) -> None:
     """End-to-end mocked test:
     model issues an mcp_approval_request, user approves, client sends mcp_approval_response.
     """