Enable more analyzers and various code tweaks/cleanup (#738)

dotnet/samples/GettingStarted/Workflows/Checkpoint/CheckpointWithHumanInTheLoop/Program.cs

@@ -57,7 +57,7 @@ public static class Program
                     // Checkpoints are automatically created at the end of each super step when a
                     // checkpoint manager is provided. You can store the checkpoint info for later use.
                     CheckpointInfo? checkpoint = superStepCompletedEvt.CompletionInfo!.Checkpoint;
-                    if (checkpoint != null)
+                    if (checkpoint is not null)
                     {
                         checkpoints.Add(checkpoint);
                         Console.WriteLine($"** Checkpoint created at step {checkpoints.Count}.");
@@ -76,9 +76,9 @@ public static class Program
         Console.WriteLine($"Number of checkpoints created: {checkpoints.Count}");
 
         // Restoring from a checkpoint and resuming execution
-        var checkpointIndex = 1;
-        Console.WriteLine($"\n\nRestoring from the {checkpointIndex + 1}th checkpoint.");
-        CheckpointInfo savedCheckpoint = checkpoints[checkpointIndex];
+        const int CheckpointIndex = 1;
+        Console.WriteLine($"\n\nRestoring from the {CheckpointIndex + 1}th checkpoint.");
+        CheckpointInfo savedCheckpoint = checkpoints[CheckpointIndex];
         // Note that we are restoring the state directly to the same run instance.
         await checkpointedRun.RestoreCheckpointAsync(savedCheckpoint, CancellationToken.None).ConfigureAwait(false);
         await foreach (WorkflowEvent evt in checkpointedRun.Run.WatchStreamAsync().ConfigureAwait(false))
@@ -109,13 +109,13 @@ public static class Program
             {
                 case NumberSignal.Init:
                     int initialGuess = ReadIntegerFromConsole("Please provide your initial guess: ");
-                    return request.CreateResponse<int>(initialGuess);
+                    return request.CreateResponse(initialGuess);
                 case NumberSignal.Above:
                     int lowerGuess = ReadIntegerFromConsole($"You previously guessed {signal.Number} too large. Please provide a new guess: ");
-                    return request.CreateResponse<int>(lowerGuess);
+                    return request.CreateResponse(lowerGuess);
                 case NumberSignal.Below:
                     int higherGuess = ReadIntegerFromConsole($"You previously guessed {signal.Number} too small. Please provide a new guess: ");
-                    return request.CreateResponse<int>(higherGuess);
+                    return request.CreateResponse(higherGuess);
             }
         }
 

dotnet/samples/GettingStarted/Workflows/Checkpoint/CheckpointWithHumanInTheLoop/WorkflowHelper.cs

@@ -20,12 +20,10 @@ internal static class WorkflowHelper
         JudgeExecutor judgeExecutor = new(42);
 
         // Build the workflow by connecting executors in a loop
-        var workflow = new WorkflowBuilder(numberInputPort)
+        return new WorkflowBuilder(numberInputPort)
             .AddEdge(numberInputPort, judgeExecutor)
             .AddEdge(judgeExecutor, numberInputPort)
             .Build<SignalWithNumber>();
-
-        return workflow;
     }
 }
 
@@ -60,7 +58,7 @@ internal sealed class SignalWithNumber
 internal sealed class JudgeExecutor() : ReflectingExecutor<JudgeExecutor>("Judge"), IMessageHandler<int>
 {
     private readonly int _targetNumber;
-    private int _tries = 0;
+    private int _tries;
     private const string StateKey = "JudgeExecutorState";
 
     /// <summary>
@@ -94,17 +92,13 @@ internal sealed class JudgeExecutor() : ReflectingExecutor<JudgeExecutor>("Judge
     /// Checkpoint the current state of the executor.
     /// This must be overridden to save any state that is needed to resume the executor.
     /// </summary>
-    protected override ValueTask OnCheckpointingAsync(IWorkflowContext context, CancellationToken cancellation = default)
-    {
-        return context.QueueStateUpdateAsync(StateKey, this._tries);
-    }
+    protected override ValueTask OnCheckpointingAsync(IWorkflowContext context, CancellationToken cancellation = default) =>
+        context.QueueStateUpdateAsync(StateKey, this._tries);
 
     /// <summary>
     /// Restore the state of the executor from a checkpoint.
     /// This must be overridden to restore any state that was saved during checkpointing.
     /// </summary>
-    protected override async ValueTask OnCheckpointRestoredAsync(IWorkflowContext context, CancellationToken cancellation = default)
-    {
+    protected override async ValueTask OnCheckpointRestoredAsync(IWorkflowContext context, CancellationToken cancellation = default) =>
         this._tries = await context.ReadStateAsync<int>(StateKey).ConfigureAwait(false);
-    }
 }