From 5bed03ee4b17a29da4ab6bb3d7a9713cb9489b0d Mon Sep 17 00:00:00 2001 From: Evan Mattson Date: Fri, 27 Feb 2026 08:29:01 +0900 Subject: [PATCH] Simplify model_id handling using walrus operator Addresses review comment on PR #4310. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../packages/core/agent_framework/azure/_responses_client.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/python/packages/core/agent_framework/azure/_responses_client.py b/python/packages/core/agent_framework/azure/_responses_client.py index a412adcaf0..2debbd7b21 100644 --- a/python/packages/core/agent_framework/azure/_responses_client.py +++ b/python/packages/core/agent_framework/azure/_responses_client.py @@ -180,10 +180,7 @@ class AzureOpenAIResponsesClient( # type: ignore[misc] client: AzureOpenAIResponsesClient[MyOptions] = AzureOpenAIResponsesClient() response = await client.get_response("Hello", options={"my_custom_option": "value"}) """ - model_id = kwargs.pop("model_id", None) - if model_id is not None and not str(model_id).strip(): - raise ValueError("model_id must not be empty") - if model_id is not None and deployment_name is None: + if (model_id := kwargs.pop("model_id", None)) and not deployment_name: deployment_name = str(model_id) # Project client path: create OpenAI client from an Azure AI Foundry project