From 53787a354a23dd47360323ec1c6ce79951ff0c2e Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 13 May 2026 19:24:08 +0000 Subject: [PATCH] Fix ValueTask compatibility with .NET Framework 4.7.2 Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/a8437809-0898-43a6-a950-09eb3417f58a Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com> --- .../RouteBuilderTests.cs | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/RouteBuilderTests.cs b/dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/RouteBuilderTests.cs index 7230a31d19..41a1d640ad 100644 --- a/dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/RouteBuilderTests.cs +++ b/dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/RouteBuilderTests.cs @@ -206,7 +206,7 @@ public sealed class RouteBuilderTests routeBuilder.AddHandlerUntyped(typeof(string), (message, context, token) => { voidInvocation.Capture(message, context, token); - return ValueTask.CompletedTask; + return default; }); routeBuilder.AddHandlerUntyped(typeof(int), (message, context, token) => { @@ -334,7 +334,7 @@ public sealed class RouteBuilderTests RouteBuilder routeBuilder = new(null); // Act - Action act = () => routeBuilder.AddPortHandler("port", (response, context, cancellationToken) => ValueTask.CompletedTask, out _); + Action act = () => routeBuilder.AddPortHandler("port", (response, context, cancellationToken) => default, out _); // Assert act.Should().Throw() @@ -351,7 +351,7 @@ public sealed class RouteBuilderTests routeBuilder.AddPortHandler("port", (response, context, cancellationToken) => { invocation.Capture(response, context, cancellationToken); - return ValueTask.CompletedTask; + return default; }, out PortBinding portBinding); await portBinding.PostRequestAsync("request", requestId: "req-1"); MessageRouter router = routeBuilder.Build(); @@ -380,7 +380,7 @@ public sealed class RouteBuilderTests // Arrange TestExternalRequestContext externalRequestContext = new(); RouteBuilder routeBuilder = new(externalRequestContext); - routeBuilder.AddPortHandler("port", (response, context, cancellationToken) => ValueTask.CompletedTask, out _); + routeBuilder.AddPortHandler("port", (response, context, cancellationToken) => default, out _); MessageRouter router = routeBuilder.Build(); ExternalRequest request = ExternalRequest.Create(RequestPort.Create("other"), "request", requestId: "req-1"); @@ -408,14 +408,14 @@ public sealed class RouteBuilderTests routeBuilder.AddHandler((message, context, cancellationToken) => { invocation.Capture(message, context, cancellationToken); - return ValueTask.CompletedTask; + return default; }); break; case HandlerOverload.AsyncWithoutCancellation: routeBuilder.AddHandler((message, context) => { invocation.Capture(message, context); - return ValueTask.CompletedTask; + return default; }); break; default: @@ -445,7 +445,7 @@ public sealed class RouteBuilderTests Func> asyncHandlerWithCancellation = (message, context, cancellationToken) => { invocation.Capture(message, context, cancellationToken); - return ValueTask.FromResult(NormalizeHandlerResult(message)); + return new ValueTask(NormalizeHandlerResult(message)); }; routeBuilder.AddHandler(asyncHandlerWithCancellation); break; @@ -453,7 +453,7 @@ public sealed class RouteBuilderTests Func> asyncHandler = (message, context) => { invocation.Capture(message, context); - return ValueTask.FromResult(NormalizeHandlerResult(message)); + return new ValueTask(NormalizeHandlerResult(message)); }; routeBuilder.AddHandler(asyncHandler); break; @@ -476,14 +476,14 @@ public sealed class RouteBuilderTests routeBuilder.AddCatchAll((message, context, cancellationToken) => { invocation.Capture(message, context, cancellationToken); - return ValueTask.CompletedTask; + return default; }); break; case HandlerOverload.AsyncWithoutCancellation: routeBuilder.AddCatchAll((message, context) => { invocation.Capture(message, context); - return ValueTask.CompletedTask; + return default; }); break; default: @@ -513,7 +513,7 @@ public sealed class RouteBuilderTests Func> asyncCatchAllWithCancellation = (message, context, cancellationToken) => { invocation.Capture(message, context, cancellationToken); - return ValueTask.FromResult(NormalizeCatchAllResult(message)); + return new ValueTask(NormalizeCatchAllResult(message)); }; routeBuilder.AddCatchAll(asyncCatchAllWithCancellation); break; @@ -521,7 +521,7 @@ public sealed class RouteBuilderTests Func> asyncCatchAll = (message, context) => { invocation.Capture(message, context); - return ValueTask.FromResult(NormalizeCatchAllResult(message)); + return new ValueTask(NormalizeCatchAllResult(message)); }; routeBuilder.AddCatchAll(asyncCatchAll); break;