From 096381d1c345a0fdc498ad44a964b196dca644fa Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Wed, 13 May 2026 19:08:19 +0000
Subject: [PATCH] Normalize edge helper bad input validation

Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/af831ee2-0a99-4427-9ffd-a3b5022c1b3b

Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
---
 .../WorkflowBuilderExtensions.cs              | 34 ++++++++++---------
 .../WorkflowBuilderSmokeTests.cs              |  4 +--
 2 files changed, 20 insertions(+), 18 deletions(-)

diff --git a/dotnet/src/Microsoft.Agents.AI.Workflows/WorkflowBuilderExtensions.cs b/dotnet/src/Microsoft.Agents.AI.Workflows/WorkflowBuilderExtensions.cs
index f9c3e2056a..b09dec91f4 100644
--- a/dotnet/src/Microsoft.Agents.AI.Workflows/WorkflowBuilderExtensions.cs
+++ b/dotnet/src/Microsoft.Agents.AI.Workflows/WorkflowBuilderExtensions.cs
@@ -25,7 +25,11 @@ public static class WorkflowBuilderExtensions
     /// <param name="target">The target executor to which messages will be forwarded.</param>
     /// <returns>The updated <see cref="WorkflowBuilder"/> instance.</returns>
     public static WorkflowBuilder ForwardMessage<TMessage>(this WorkflowBuilder builder, ExecutorBinding source, ExecutorBinding target)
-        => builder.ForwardMessage<TMessage>(source, [target], condition: null);
+    {
+        Throw.IfNull(target);
+
+        return builder.ForwardMessage<TMessage>(source, [target], condition: null);
+    }
 
     /// <summary>
     /// Adds edges to the workflow that forward messages of the specified type from the source executor to
@@ -57,17 +61,14 @@ public static class WorkflowBuilderExtensions
         Throw.IfNull(targets);
 
         Func<object?, bool> predicate = WorkflowBuilder.CreateConditionFunc<TMessage>(IsAllowedTypeAndMatchingCondition)!;
+        List<ExecutorBinding> targetList = targets.Select(target => Throw.IfNull(target, nameof(targets))).ToList();
 
-#if NET
-        if (targets.TryGetNonEnumeratedCount(out int count) && count == 1)
-#else
-        if (targets is ICollection<ExecutorBinding> { Count: 1 })
-#endif
+        if (targetList.Count == 1)
         {
-            return builder.AddEdge(source, targets.First(), predicate);
+            return builder.AddEdge(source, targetList[0], predicate);
         }
 
-        return builder.AddSwitch(source, (switch_) => switch_.AddCase(predicate, targets));
+        return builder.AddSwitch(source, (switch_) => switch_.AddCase(predicate, targetList));
 
         // The reason we can check for "not null" here is that CreateConditionFunc<T> will do the correct unwrapping
         // logic for PortableValues.
@@ -83,7 +84,11 @@ public static class WorkflowBuilderExtensions
     /// <param name="target">The target executor to which messages, except those of type <typeparamref name="TMessage"/>, will be forwarded.</param>
     /// <returns>The updated <see cref="WorkflowBuilder"/> instance with the added edges.</returns>
     public static WorkflowBuilder ForwardExcept<TMessage>(this WorkflowBuilder builder, ExecutorBinding source, ExecutorBinding target)
-        => builder.ForwardExcept<TMessage>(source, [target]);
+    {
+        Throw.IfNull(target);
+
+        return builder.ForwardExcept<TMessage>(source, [target]);
+    }
 
     /// <summary>
     /// Adds edges from the specified source to the provided executors, excluding messages of a specified type.
@@ -100,17 +105,14 @@ public static class WorkflowBuilderExtensions
         Throw.IfNull(targets);
 
         Func<object?, bool> predicate = WorkflowBuilder.CreateConditionFunc<TMessage>((Func<object?, bool>)IsAllowedType)!;
+        List<ExecutorBinding> targetList = targets.Select(target => Throw.IfNull(target, nameof(targets))).ToList();
 
-#if NET
-        if (targets.TryGetNonEnumeratedCount(out int count) && count == 1)
-#else
-        if (targets is ICollection<ExecutorBinding> { Count: 1 })
-#endif
+        if (targetList.Count == 1)
         {
-            return builder.AddEdge(source, targets.First(), predicate);
+            return builder.AddEdge(source, targetList[0], predicate);
         }
 
-        return builder.AddSwitch(source, (switch_) => switch_.AddCase(predicate, targets));
+        return builder.AddSwitch(source, (switch_) => switch_.AddCase(predicate, targetList));
 
         // The reason we can check for "null" here is that CreateConditionFunc<T> will do the correct unwrapping
         // logic for PortableValues.
diff --git a/dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/WorkflowBuilderSmokeTests.cs b/dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/WorkflowBuilderSmokeTests.cs
index 1ca2027446..a44bd9ad8b 100644
--- a/dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/WorkflowBuilderSmokeTests.cs
+++ b/dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/WorkflowBuilderSmokeTests.cs
@@ -368,7 +368,7 @@ public partial class WorkflowBuilderSmokeTests
         Assert.Throws<ArgumentNullException>("source", () => builder.ForwardMessage<string>(null!, target));
         Assert.Throws<ArgumentNullException>("target", () => builder.ForwardMessage<string>(source, (ExecutorBinding)null!));
         Assert.Throws<ArgumentNullException>("targets", () => builder.ForwardMessage<string>(source, (IEnumerable<ExecutorBinding>)null!));
-        Assert.Throws<ArgumentNullException>("executors", () => builder.ForwardMessage<string>(source, [target, null!]));
+        Assert.Throws<ArgumentNullException>("targets", () => builder.ForwardMessage<string>(source, [target, null!]));
         Assert.Throws<ArgumentException>("targets", () => builder.ForwardMessage<string>(source, []));
     }
 
@@ -385,7 +385,7 @@ public partial class WorkflowBuilderSmokeTests
         Assert.Throws<ArgumentNullException>("source", () => builder.ForwardExcept<string>(null!, target));
         Assert.Throws<ArgumentNullException>("target", () => builder.ForwardExcept<string>(source, (ExecutorBinding)null!));
         Assert.Throws<ArgumentNullException>("targets", () => builder.ForwardExcept<string>(source, (IEnumerable<ExecutorBinding>)null!));
-        Assert.Throws<ArgumentNullException>("executors", () => builder.ForwardExcept<string>(source, [target, null!]));
+        Assert.Throws<ArgumentNullException>("targets", () => builder.ForwardExcept<string>(source, [target, null!]));
         Assert.Throws<ArgumentException>("targets", () => builder.ForwardExcept<string>(source, []));
     }