agent/agent-framework
2
0
Fork 0
mirror of https://github.com/microsoft/agent-framework.git synced 2026-06-16 21:04:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

Enable instrumentation by default

Browse Source
This commit is contained in:
Tao Chen
2026-05-14 13:42:00 -07:00
Unverified
parent 7432105ebe
commit 0219e17be2
23 changed files with 104 additions and 205 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/packages/foundry/agent_framework_foundry/_agent.py
+3 -2
View File
@@ -817,7 +817,7 @@ class RawFoundryAgent( # type: ignore[misc]
"Install it with: pip install azure-monitor-opentelemetry"
) from exc
from agent_framework.observability import create_metric_views, create_resource, enable_instrumentation
from agent_framework.observability import create_metric_views, create_resource, enable_sensitive_telemetry
if "resource" not in kwargs:
kwargs["resource"] = create_resource()
@@ -828,7 +828,8 @@ class RawFoundryAgent( # type: ignore[misc]
**kwargs,
)
enable_instrumentation(enable_sensitive_data=enable_sensitive_data)
if enable_sensitive_data:
enable_sensitive_telemetry()
class FoundryAgent( # type: ignore[misc]
python/packages/foundry/agent_framework_foundry/_chat_client.py
+3 -2
View File
@@ -291,7 +291,7 @@ class RawFoundryChatClient( # type: ignore[misc]
"Install it with: pip install azure-monitor-opentelemetry"
) from exc
from agent_framework.observability import create_metric_views, create_resource, enable_instrumentation
from agent_framework.observability import create_metric_views, create_resource, enable_sensitive_telemetry
if "resource" not in kwargs:
kwargs["resource"] = create_resource()
@@ -302,7 +302,8 @@ class RawFoundryChatClient( # type: ignore[misc]
**kwargs,
)
enable_instrumentation(enable_sensitive_data=enable_sensitive_data)
if enable_sensitive_data:
enable_sensitive_telemetry()
# region Tool factory methods (override OpenAI defaults with Foundry versions)
python/packages/foundry/tests/foundry/test_foundry_agent.py
+2 -2
View File
@@ -699,7 +699,7 @@ async def test_foundry_agent_configure_azure_monitor() -> None:
),
patch("agent_framework.observability.create_metric_views", mock_views),
patch("agent_framework.observability.create_resource", return_value=mock_resource),
patch("agent_framework.observability.enable_instrumentation", mock_enable),
patch("agent_framework.observability.enable_sensitive_telemetry", mock_enable),
):
await agent.configure_azure_monitor(enable_sensitive_data=True)
@@ -708,7 +708,7 @@ async def test_foundry_agent_configure_azure_monitor() -> None:
assert call_kwargs["connection_string"] == "InstrumentationKey=test-key;IngestionEndpoint=https://test.endpoint"
assert call_kwargs["views"] == []
assert call_kwargs["resource"] is mock_resource
mock_enable.assert_called_once_with(enable_sensitive_data=True)
mock_enable.assert_called_once()
async def test_foundry_agent_configure_azure_monitor_resource_not_found() -> None:
python/packages/foundry/tests/foundry/test_foundry_chat_client.py
+3 -3
View File
@@ -249,7 +249,7 @@ async def test_configure_azure_monitor() -> None:
),
patch("agent_framework.observability.create_metric_views", mock_views),
patch("agent_framework.observability.create_resource", return_value=mock_resource),
patch("agent_framework.observability.enable_instrumentation", mock_enable),
patch("agent_framework.observability.enable_sensitive_telemetry", mock_enable),
):
await client.configure_azure_monitor(enable_sensitive_data=True)
@@ -259,7 +259,7 @@ async def test_configure_azure_monitor() -> None:
assert call_kwargs["connection_string"] == "InstrumentationKey=test-key;IngestionEndpoint=https://test.endpoint"
assert call_kwargs["views"] == []
assert call_kwargs["resource"] is mock_resource
mock_enable.assert_called_once_with(enable_sensitive_data=True)
mock_enable.assert_called_once()
async def test_configure_azure_monitor_resource_not_found() -> None:
@@ -324,7 +324,7 @@ async def test_configure_azure_monitor_with_custom_resource() -> None:
),
patch("agent_framework.observability.create_metric_views", return_value=[]),
patch("agent_framework.observability.create_resource") as mock_create_resource,
patch("agent_framework.observability.enable_instrumentation"),
patch("agent_framework.observability.enable_sensitive_telemetry"),
):
await client.configure_azure_monitor(resource=custom_resource)