From d11a9bb1c98606f8f97f8e2196203fcb2b582f18 Mon Sep 17 00:00:00 2001
From: Nikola Chetelyazov <nikola.chetelyazov@gmail.com>
Date: Mon, 13 Apr 2026 09:56:12 +0300
Subject: [PATCH] refactor: extract addChildNode helper to remove repeated
 boilerplate

All five child-node loops in addNonCodeFileWithAnalysis shared the same four-line pattern: dedup check, nodeIds.add, nodes.push, and a contains edge push. A private addChildNode helper centralises this so each loop only constructs the node object specific to its type.
---
 .../core/src/analyzer/graph-builder.ts        | 77 +++++++------------
 1 file changed, 26 insertions(+), 51 deletions(-)

diff --git a/understand-anything-plugin/packages/core/src/analyzer/graph-builder.ts b/understand-anything-plugin/packages/core/src/analyzer/graph-builder.ts
index 3a35034..d34d723 100644
--- a/understand-anything-plugin/packages/core/src/analyzer/graph-builder.ts
+++ b/understand-anything-plugin/packages/core/src/analyzer/graph-builder.ts
@@ -289,14 +289,8 @@ export class GraphBuilder {
 
     // Create child nodes for definitions (tables, schemas, etc.)
     for (const def of meta.definitions ?? []) {
-      const childId = `${def.kind}:${filePath}:${def.name}`;
-      if (this.nodeIds.has(childId)) {
-        console.warn(`[GraphBuilder] Duplicate node ID "${childId}" — skipping`);
-        continue;
-      }
-      this.nodeIds.add(childId);
-      this.nodes.push({
-        id: childId,
+      this.addChildNode({
+        id: `${def.kind}:${filePath}:${def.name}`,
         type: this.mapKindToNodeType(def.kind),
         name: def.name,
         filePath,
@@ -304,41 +298,27 @@ export class GraphBuilder {
         summary: `${def.kind}: ${def.name} (${def.fields.length} fields)`,
         tags: [],
         complexity: meta.complexity,
-      });
-      this.edges.push({ source: fileId, target: childId, type: "contains", direction: "forward", weight: 1 });
+      }, fileId);
     }
 
     // Create child nodes for services
     for (const svc of meta.services ?? []) {
-      const childId = `service:${filePath}:${svc.name}`;
-      if (this.nodeIds.has(childId)) {
-        console.warn(`[GraphBuilder] Duplicate node ID "${childId}" — skipping`);
-        continue;
-      }
-      this.nodeIds.add(childId);
-      this.nodes.push({
-        id: childId,
+      this.addChildNode({
+        id: `service:${filePath}:${svc.name}`,
         type: "service",
         name: svc.name,
         filePath,
         summary: `Service ${svc.name}${svc.image ? ` (image: ${svc.image})` : ""}`,
         tags: [],
         complexity: meta.complexity,
-      });
-      this.edges.push({ source: fileId, target: childId, type: "contains", direction: "forward", weight: 1 });
+      }, fileId);
     }
 
     // Create child nodes for endpoints
     for (const ep of meta.endpoints ?? []) {
-      const childId = `endpoint:${filePath}:${ep.path}`;
-      if (this.nodeIds.has(childId)) {
-        console.warn(`[GraphBuilder] Duplicate node ID "${childId}" — skipping`);
-        continue;
-      }
-      const name = `${ep.method ?? ""} ${ep.path}`.trim()
-      this.nodeIds.add(childId);
-      this.nodes.push({
-        id: childId,
+      const name = `${ep.method ?? ""} ${ep.path}`.trim();
+      this.addChildNode({
+        id: `endpoint:${filePath}:${ep.path}`,
         type: "endpoint",
         name,
         filePath,
@@ -346,20 +326,13 @@ export class GraphBuilder {
         summary: `Endpoint: ${name}`,
         tags: [],
         complexity: meta.complexity,
-      });
-      this.edges.push({ source: fileId, target: childId, type: "contains", direction: "forward", weight: 1 });
+      }, fileId);
     }
 
     // Create child nodes for steps (pipeline/makefile targets)
     for (const step of meta.steps ?? []) {
-      const childId = `step:${filePath}:${step.name}`;
-      if (this.nodeIds.has(childId)) {
-        console.warn(`[GraphBuilder] Duplicate node ID "${childId}" — skipping`);
-        continue;
-      }
-      this.nodeIds.add(childId);
-      this.nodes.push({
-        id: childId,
+      this.addChildNode({
+        id: `step:${filePath}:${step.name}`,
         type: "pipeline",
         name: step.name,
         filePath,
@@ -367,20 +340,13 @@ export class GraphBuilder {
         summary: `Step: ${step.name}`,
         tags: [],
         complexity: meta.complexity,
-      });
-      this.edges.push({ source: fileId, target: childId, type: "contains", direction: "forward", weight: 1 });
+      }, fileId);
     }
 
     // Create child nodes for resources (Terraform, etc.)
     for (const res of meta.resources ?? []) {
-      const childId = `resource:${filePath}:${res.name}`;
-      if (this.nodeIds.has(childId)) {
-        console.warn(`[GraphBuilder] Duplicate node ID "${childId}" — skipping`);
-        continue;
-      }
-      this.nodeIds.add(childId);
-      this.nodes.push({
-        id: childId,
+      this.addChildNode({
+        id: `resource:${filePath}:${res.name}`,
         type: "resource",
         name: res.name,
         filePath,
@@ -388,11 +354,20 @@ export class GraphBuilder {
         summary: `Resource: ${res.name} (${res.kind})`,
         tags: [],
         complexity: meta.complexity,
-      });
-      this.edges.push({ source: fileId, target: childId, type: "contains", direction: "forward", weight: 1 });
+      }, fileId);
     }
   }
 
+  private addChildNode(node: GraphNode, parentId: string): void {
+    if (this.nodeIds.has(node.id)) {
+      console.warn(`[GraphBuilder] Duplicate node ID "${node.id}" — skipping`);
+      return;
+    }
+    this.nodeIds.add(node.id);
+    this.nodes.push(node);
+    this.edges.push({ source: parentId, target: node.id, type: "contains", direction: "forward", weight: 1 });
+  }
+
   private mapKindToNodeType(kind: string): GraphNode["type"] {
     const mapped = KIND_TO_NODE_TYPE[kind];
     if (!mapped) {